Improved context when exiting with error #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chore: fixed a few linter issues, including two unhandled error cases note: may want to improve what happens in those cases
ddlees
reviewed
Jan 27, 2023
ddlees
reviewed
Jan 27, 2023
chore: added break if currentTask errors and updated log message chore: fixed several instances of bad json tags that were flagged by go vet
ddlees
approved these changes
Jan 31, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: added context to every exit()
chore: refactored common connectionTest() and newAzureClient() calls into its own reusable function
chore: fixed a few linter issues, including two unhandled error cases
chore: added break if currentTask errors and updated log message
chore: fixed several instances of bad json tags that were flagged by go vet