Fix step kind detection when language is declared in file comment. #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Fix #27 |
Socolin
force-pushed
the
fix-steps-language
branch
2 times, most recently
from
83647d4
to
c587dbe
Compare
|
I changed it. It's now using the regex |
- Step kind is now detected during parsing (GherkinParser) and stored inside GherkinStep: No more complex code to compute this, it's already computed - When parsing language, create a new node GherkinLanguageComment if we need to access this later (syntax highlight ?, check language is known ?) - Store language into GherkinFile for future use (Keyword completion)
nemesv
force-pushed
the
fix-steps-language
branch
from
c587dbe
to
4acb1e1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GherkinStep: No more complex code to compute this, it's already computed
need to access this later (syntax highlight ?, check language is known ?)