-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Step Completion #36
Step Completion #36
Conversation
...cflowRiderPlugin/Caching/StepsDefinitions/AssemblyStepDefinitions/SpecflowStepInfoFactory.cs
Outdated
Show resolved
Hide resolved
...net/ReSharperPlugin.SpecflowRiderPlugin/CompletionProviders/GherkinStepCompletionProvider.cs
Outdated
Show resolved
Hide resolved
.../ReSharperPlugin.SpecflowRiderPlugin/CompletionProviders/GherkinKeywordCompletionProvider.cs
Outdated
Show resolved
Hide resolved
The documentation is very good and helpful to understand the feature. 👍 |
For example: Step pattern: Given that (Bob|Alice) is doing something Will expand into 2 completion suggestion: - Given that Bob is doing something is here - Given that Alice is doing something is here
… in a loop, this can be done before
@Socolin it seems with the namespace rename something has changed in the build order, and the generation of the CSharpErrors.generated.cs is executed later which fails the build. Locally in Rider it is always working, manually executing the buildPlugin gradle task is working mostly... What I've tried to delete |
Yes I do not understand what is the problem, I'll take a look during the weekend |
…was it was iterating over the 65000 values and creating state for each when using `.`
…into multiple choice)
So I had to optimize some stuff in the Regex library, it was taking 3 minutes to parse the regex in my work project (not that big) so it was not usable. Now it feel reactive and quick enough, this problem should be defenitively fixed once we can use PCRE.NET for this. After testing with my projects I also found some details, when a step contains a Completion is also now handling optional group / characters correctly (when there are |
See documentation in doc/how-it-works/completion.md
Reviews are welcome.
I want to add some tests too, there are a lot of edge case here.