Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Step Completion #36

Merged
merged 25 commits into from
Mar 7, 2021
Merged

Step Completion #36

merged 25 commits into from
Mar 7, 2021

Conversation

Socolin
Copy link
Collaborator

@Socolin Socolin commented Mar 4, 2021

See documentation in doc/how-it-works/completion.md

Reviews are welcome.
I want to add some tests too, there are a lot of edge case here.

@Socolin Socolin added the enhancement New feature or request label Mar 4, 2021
@nemesv
Copy link
Contributor

nemesv commented Mar 5, 2021

The documentation is very good and helpful to understand the feature. 👍

@nemesv
Copy link
Contributor

nemesv commented Mar 5, 2021

@Socolin it seems with the namespace rename something has changed in the build order, and the generation of the CSharpErrors.generated.cs is executed later which fails the build.

Locally in Rider it is always working, manually executing the buildPlugin gradle task is working mostly...
But it was also failed 2 times, however I cannot really reproduce it anymore.

What I've tried to delete CSharpErrors.generated.cs and rerun the task, but in most cases it works. However in the build it always fails. I've tried to restart multiple times.

@Socolin
Copy link
Collaborator Author

Socolin commented Mar 5, 2021

Yes I do not understand what is the problem, I'll take a look during the weekend

@Socolin
Copy link
Collaborator Author

Socolin commented Mar 7, 2021

So I had to optimize some stuff in the Regex library, it was taking 3 minutes to parse the regex in my work project (not that big) so it was not usable. Now it feel reactive and quick enough, this problem should be defenitively fixed once we can use PCRE.NET for this.

After testing with my projects I also found some details, when a step contains a \( or \) etc.. so I Unescape the pattern before showing it in completion

Completion is also now handling optional group / characters correctly (when there are ? in pattern)

@nemesv nemesv merged commit 068532e into master Mar 7, 2021
@Socolin Socolin deleted the completion branch March 7, 2021 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants