Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update phpspreadsheet to 1.29.8 to tackle CVE issue #4264

Merged
merged 1 commit into from
Jan 23, 2025

Conversation

brdv
Copy link
Contributor

@brdv brdv commented Jan 23, 2025

Please take note of our contributing guidelines: https://docs.laravel-excel.com/3.1/getting-started/contributing.html
Filling out the template is required. Any pull request that does not include enough information to be reviewed in a timely manner may be closed at the maintainers' discretion.

1️⃣ Why should it be added? What are the benefits of this change?
To tackle CVE-2025-22131.

2️⃣ Does it contain multiple, unrelated changes? Please separate the PRs out.
No, just composer updates.

3️⃣ Does it include tests, if possible?
Nope.

4️⃣ Any drawbacks? Possible breaking changes?
No, just a patch update of a dependency.

5️⃣ Mark the following tasks as done:

  • Checked the codebase to ensure that your feature doesn't already exist.
  • Take note of the contributing guidelines.
  • Checked the pull requests to ensure that another person hasn't already submitted a fix.
  • Added tests to ensure against regression.

6️⃣ Thanks for contributing! 🙌

@patrickbrouwers patrickbrouwers merged commit e7d7585 into SpartnerNL:3.1 Jan 23, 2025
19 checks passed
@brdv brdv deleted the fix/CVE-2025-22131 branch January 24, 2025 08:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants