Feature: Develop CTA & Footer #46
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tigawanna
reviewed
Dec 11, 2024
src/routes/-components/FooterCTA.tsx
Outdated
| return ( | ||
| <div | ||
| data-test="FooterCTA" | ||
| className="relative flex flex-col items-center gap-4 p-4 md:gap-10 lg:flex lg:flex-row lg:p-[100px] lg:pl-[20%]" |
There was a problem hiding this comment.
consider removing the realtive style to make sure it's properly positioned when scrolled to the end
There was a problem hiding this comment.
I have corrected this to ensure it scrolls well to the end without the initial empty space
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Develop CTA & Footer (#18)
📋 Description:
This pull request addresses Issue #18, focusing on creating the CTA and footer section within the home page. The aim was to replicate the design, ensure a modern, responsive user interface and write e2e tests for the components.
✅ What Was Done:
-[X] Write e2e tests in the tests folder, to test the components' look, feel, and functionality