feat: add repositories section #30
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
vfshera
commented
Nov 22, 2024
vfshera
commented
- Develop the repositories section on the landing page per the Figma designs
- Make sure the components are fully responsive
- Write Unit and e2e tests in the tests folder, to test the components' look, feel, and functionality
- Include a list of any API endpoints required in the pull request description, if applicable
tigawanna
reviewed
Nov 25, 2024
package.json
Outdated
| @@ -62,6 +62,7 @@ | |||
| "react-to-print": "^2.15.1", | |||
| "recharts": "^2.12.7", | |||
| "sonner": "^1.5.0", | |||
| "swiper": "^11.1.15", | |||
There was a problem hiding this comment.
would be nice if tried to avoid extra dependancies until absolutely necessary
tigawanna
reviewed
Nov 25, 2024
| }, [projects, searchTerm, selectedLanguage]); | ||
|
|
||
| return ( | ||
| <section className="border-y border-[#294740] px-5 pb-16 pt-5"> |
There was a problem hiding this comment.
let's try and centralize all the colors in our tailwind config and only use tokens
There was a problem hiding this comment.
giving the section w-full will help it be responsive on mobile , also abstanin from positioning using padding preffer using flexbox or gird
tigawanna
reviewed
Nov 25, 2024
|
|
||
| <div className="mt-[30px] grid gap-x-8 gap-y-[30px] md:grid-cols-2 lg:grid-cols-3"> | ||
| {searchedProjects.map((project) => ( | ||
| <div className="relative isolate overflow-hidden rounded-[12px] border border-[#294740]/80 bg-[#413535]/[.53] px-4 pb-5 pt-7"> |
tigawanna
reviewed
Nov 25, 2024
| <div className="mt-[30px] grid gap-x-8 gap-y-[30px] md:grid-cols-2 lg:grid-cols-3"> | ||
| {searchedProjects.map((project) => ( | ||
| <div className="relative isolate overflow-hidden rounded-[12px] border border-[#294740]/80 bg-[#413535]/[.53] px-4 pb-5 pt-7"> | ||
| <svg |
There was a problem hiding this comment.
let's try and centralize all the inlined svg ocons inside the src/components/wrappers/custom-icons.tsx file
tigawanna
reviewed
Nov 25, 2024
| </div> | ||
|
|
||
| <div className="mt-5"> | ||
| <Swiper |
There was a problem hiding this comment.
if possible explain or show a demo of what the Swipper dependancy will help achieve
|
looks better but still a few nitpicks
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.