Skip to content

Commit

Permalink
preonic/rev3{,_drop}: Fix layouts with 2u keys (qmk#21114)
Browse files Browse the repository at this point in the history 
Apparently layouts with 2u keys were not correctly converted into the
`info.json` format (the old C layout macros used the arguments for such
keys multiple times to cover all possible 1u locations; this is not
supported in `info.json`, and the single matrix location for 2u keys was
chosen incorrectly in some cases).  Fix the layout definitions to match
the real PCB wiring.
  • Loading branch information
@sigprof @autoferrit
sigprof authored and autoferrit committed Dec 6, 2023
1 parent cbf12f6 commit 193da47
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 6 deletions.
8 changes: 4 additions & 4 deletions keyboards/preonic/rev3/info.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -93,7 +93,7 @@
{"matrix": [8, 2], "x": 2, "y": 4},
{"matrix": [9, 3], "x": 3, "y": 4},
{"matrix": [9, 4], "x": 4, "y": 4},
{"matrix": [9, 5], "x": 5, "y": 4, "w": 2},
{"matrix": [9, 0], "x": 5, "y": 4, "w": 2},
{"matrix": [9, 1], "x": 7, "y": 4},
{"matrix": [9, 2], "x": 8, "y": 4},
{"matrix": [8, 3], "x": 9, "y": 4},
Expand Down Expand Up @@ -226,7 +226,7 @@
{"matrix": [8, 1], "x": 1, "y": 4},
{"matrix": [8, 2], "x": 2, "y": 4},
{"matrix": [9, 3], "x": 3, "y": 4},
{"matrix": [9, 4], "x": 4, "y": 4, "w": 2},
{"matrix": [9, 5], "x": 4, "y": 4, "w": 2},
{"matrix": [9, 0], "x": 6, "y": 4},
{"matrix": [9, 1], "x": 7, "y": 4},
{"matrix": [9, 2], "x": 8, "y": 4},
Expand Down Expand Up @@ -293,8 +293,8 @@
{"matrix": [8, 1], "x": 1, "y": 4},
{"matrix": [8, 2], "x": 2, "y": 4},
{"matrix": [9, 3], "x": 3, "y": 4},
{"matrix": [9, 4], "x": 4, "y": 4, "w": 2},
{"matrix": [9, 0], "x": 6, "y": 4, "w": 2},
{"matrix": [9, 5], "x": 4, "y": 4, "w": 2},
{"matrix": [9, 1], "x": 6, "y": 4, "w": 2},
{"matrix": [9, 2], "x": 8, "y": 4},
{"matrix": [8, 3], "x": 9, "y": 4},
{"matrix": [8, 4], "x": 10, "y": 4},
Expand Down
4 changes: 2 additions & 2 deletions keyboards/preonic/rev3_drop/info.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,7 @@
{"matrix": [8, 2], "x": 2, "y": 4},
{"matrix": [9, 3], "x": 3, "y": 4},
{"matrix": [9, 4], "x": 4, "y": 4},
{"matrix": [9, 5], "x": 5, "y": 4, "w": 2},
{"matrix": [9, 0], "x": 5, "y": 4, "w": 2},
{"matrix": [9, 1], "x": 7, "y": 4},
{"matrix": [9, 2], "x": 8, "y": 4},
{"matrix": [8, 3], "x": 9, "y": 4},
Expand Down Expand Up @@ -293,7 +293,7 @@
{"matrix": [8, 2], "x": 2, "y": 4},
{"matrix": [9, 3], "x": 3, "y": 4},
{"matrix": [9, 5], "x": 4, "y": 4, "w": 2},
{"matrix": [9, 0], "x": 6, "y": 4, "w": 2},
{"matrix": [9, 1], "x": 6, "y": 4, "w": 2},
{"matrix": [9, 2], "x": 8, "y": 4},
{"matrix": [8, 3], "x": 9, "y": 4},
{"matrix": [8, 4], "x": 10, "y": 4},
Expand Down

0 comments on commit 193da47

Please sign in to comment.