Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove error if a proc has both should_not_sleep and set waitfor = 0 #211

Merged
merged 1 commit into from
Sep 9, 2020
+0 −7
Merged

Remove error if a proc has both should_not_sleep and set waitfor = 0 #211

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 0 additions & 7 deletions src/dreamchecker/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -632,13 +632,6 @@ impl<'o> AnalyzeObjectTree<'o> {

pub fn check_proc_call_tree(&mut self) {
for (procref, &(_, location)) in self.must_not_sleep.directive.iter() {
if let Some(_) = self.waitfor_procs.get(&procref) {
error(procref.get().location, format!("{} sets SpacemanDMM_should_not_sleep but also sets waitfor = 0", procref))
.with_note(location, "SpacemanDMM_should_not_sleep set here")
.with_errortype("must_not_sleep")
.register(self.context);
continue
}
if let Some(sleepvec) = self.sleeping_procs.get_violators(*procref) {
error(procref.get().location, format!("{} sets SpacemanDMM_should_not_sleep but calls blocking built-in(s)", procref))
.with_note(location, "SpacemanDMM_should_not_sleep set here")
Expand Down