Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DM-Langserver does not know about builtin Filter flags #205

Closed
Neerti opened this issue Aug 13, 2020 · 0 comments · Fixed by #206
Closed

DM-Langserver does not know about builtin Filter flags #205

Neerti opened this issue Aug 13, 2020 · 0 comments · Fixed by #206
Labels
bug good first issue
Milestone
suite v1.6

Comments

@Neerti
Copy link
Contributor

Neerti commented Aug 13, 2020

BYOND has a large number of built in flags, and I assume that the fairly new BYOND visual filter flags have yet to get added to a list of built in flags. The result is that using one of those flags results in an erroneous unknown variable error, when it compiles just fine. The flag in question is OUTLINE_SHARP for the outline filter, as seen in this picture.

After doing some research, the built in flag definitions seem to be located here so I'm not sure if it's as simple as just adding them so the language server stops thinking it's an undefined variable. If it actually is just that simple then I can try to fix it, and #195 seems to suggest that it would be an easy fix, hopefully.
@Neerti Neerti mentioned this issue Aug 14, 2020
Merged
SpaceManiac pushed a commit that referenced this issue Aug 15, 2020
@Neerti
Add missing filter flags for the outline filter (#206)
235ae71 
Fixes #205.

Tried to fix the issue I found last night in the same way that #165 
added other filter flags, but that PR seemed to have forgotten to add 
the two outline flags.

I tested this locally and the error doesn't come up now so it does work.
@SpaceManiac SpaceManiac added this to the suite v1.6 milestone Sep 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug good first issue
Projects
None yet
Milestone
suite v1.6
Development

Successfully merging a pull request may close this issue.

Adds missing filter flags for the outline filter. Neerti/SpacemanDMM
2 participants
@SpaceManiac @Neerti