Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

; in proc arguments causes a fatal parse error #172

Closed
spookydonut opened this issue Apr 1, 2020 · 1 comment · Fixed by #176
Closed

; in proc arguments causes a fatal parse error #172

spookydonut opened this issue Apr 1, 2020 · 1 comment · Fixed by #176

Comments

@spookydonut
Copy link
Collaborator

PolarisSS13/Polaris#6941

@Cyberboss
Copy link
Contributor

Cyberboss commented Apr 3, 2020

[11:05 AM] spookydonut:

#define SOMESHIT 0x01;

/proc/fuck(foo = SOMESHIT, anotherarg = 1)

[11:05 AM] spookydonut: that should do it
[11:07 AM] Cyberboss: Hmm, what launch args?
[11:07 AM] Cyberboss: Forgive me, I'm a rust baby
[11:07 AM] spookydonut:

PS D:\git\SpacemanDMM\target\debug> .\dreamchecker.exe -e test.dm
============================================================
Parsing test.dm...

test.dm, line 3, column 18:
error: got ';', expected one of: operator, field access, as, 'in', ')', ','
- fatal error: the parser cannot continue
- constant evaluation will be skipped
Saving this for later

image

Cyberboss added a commit to Cyberboss/SpacemanDMM that referenced this issue Apr 7, 2020
Optionally allow trailing `;`s after the expression in proc arguments. Emit a warning when doing so.

Fixes SpaceManiac#172
Cyberboss added a commit to Cyberboss/SpacemanDMM that referenced this issue Apr 7, 2020
Optionally allow trailing `;`s after the expression in proc arguments. Emit a warning when doing so.

Fixes SpaceManiac#172
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants