Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix disambiguations #45

Merged
merged 1 commit into from
Aug 22, 2023
Merged

Fix disambiguations #45

merged 1 commit into from
Aug 22, 2023

Conversation

bastien-phi
Copy link
Member

Select returns the key of the element in the options, not it's value.

Fixes #44

@qanvo Can you check this fix using composer require --dev soyhuce/laravel:somake:dev-fix_disambiguations ?

@qanvo
Copy link

qanvo commented Aug 21, 2023

Perfect, this fix does the job.

@bastien-phi bastien-phi merged commit f68c5ee into main Aug 22, 2023
@bastien-phi bastien-phi deleted the fix_disambiguations branch August 22, 2023 06:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Selected choice from the suggest dropdown returns incorrect value
2 participants