Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for issue 34, switched this.$el with evt.from #52

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

alnumac
Copy link

@alnumac alnumac commented Jun 3, 2021

onDragUpdate was updated to use evt.from to call insertNodeAt, but onDragRemove was not updated accordingly.

This pull request simply corrects this slight oversight, fixing a crash I was experiencing.

onDragUpdate was updated to use evt.from to call insertNodeAt, but onDragRemove was not updated accordingly.
@alnumac alnumac changed the title Fix for issue 51, switched this.$el with evt.from Fix for issue 34, switched this.$el with evt.from Jun 3, 2021
@David-Desmaisons
Copy link
Member

@alnumac Could you specify which scenario this fix is correcting?

@alnumac
Copy link
Author

alnumac commented Sep 4, 2021

@David-Desmaisons Moving an item from one list to another with animations enabled.

@cybersturmer
Copy link

Yes, i have the same problem, and looking for this. fix. Have to disable animation for current version. There is no such problem for previous vue2 version.

@atom-git
Copy link

Please correct this bug and push a new release! Thank you So much!

@JanLunge
Copy link

JanLunge commented Dec 7, 2021

I also would be in favor of merging and releasing this as I just now ran into the same issue while upgrading a vue2 project to vue3 and moving items between lists of the same group throws the Cannot read properties of undefined error inside the onDragRemove function, I'm also using the transition-group with the animation prop.
only workaround for now is removing the transition-group and the animation prop

@Coding-Kiwi
Copy link

@David-Desmaisons what is missing for this to be merged?

@vform666
Copy link

Please merge this PR and push a new release!
Thanks very much!

atom-git added a commit to atom-git/vue.draggable that referenced this pull request Feb 15, 2023
solve drag between two group occur undefined problem, like offical pull request, SortableJS#52
Fix for issue 34, switched this.$el with evt.from SortableJS#52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants