Fix to drop before first child #1961
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ortableJS#1875) * deps: install dev-deps for ts, tests and friends * tests: replace test.js with test.ts and fp * change compat tests * ci: replace tests to use npm as per usual
…1878) The doc was missing the case of keeping the default insertion point based on the direction.
* refactor(tests): move HTML fixtures into own dir * refactor(tests): separate e2e tests into folders * refactor(deps): packagejson reformat * refactor(deps): remove cypress from dev deps * refactor(ci): add description to circleci
* refactor(tests): move HTML fixtures into own dir * refactor(tests): separate e2e tests into folders * refactor(deps): packagejson reformat * refactor(deps): remove cypress from dev deps * refactor(ci): add description to circleci * build: bundles with rollup ^2.14 and typescript * dist: create new dist files * chore: bump minor version * build(refactor): removes unused babel plugin
* build: upgrade to 1.11.0 * tests(fix): emit exit code 1 on fail
* build: upgrade to 1.11.0 * tests(fix): emit exit code 1 on fail * refactor: microbundle and typescript * ci: ensure lerna is globally available * build: use yarn and workspaces * use lerna * build: add private to sortbale repo * v1.11.1 * ci: use yarn and lerna together * fix ci * tests: fix tests
…S#1914) * refactor: remove code formattings config files * docs: add more detail to contribution guidelines * docs: remove custom templates * docs: update bug report issue * docs: add discussion template * docs: update featue template
…-links Readme invalid hyperlinks corrected
…ableJS#1921) * refactor: remove code formattings config files * docs: add more detail to contribution guidelines * docs: remove custom templates * docs: update bug report issue * docs: add discussion template * docs: update featue template * fix(build): build dist/sortablejs, was missing prior * build(deps): yarn upgrade * v1.11.2-alpha.4
* refactor: remove code formattings config files * docs: add more detail to contribution guidelines * docs: remove custom templates * docs: update bug report issue * docs: add discussion template * docs: update featue template * fix(build): build dist/sortablejs, was missing prior * build(deps): yarn upgrade * v1.11.2-alpha.4
* refactor: remove code formattings config files * docs: add more detail to contribution guidelines * docs: remove custom templates * docs: update bug report issue * docs: add discussion template * docs: update featue template * fix(build): build dist/sortablejs, was missing prior * build(deps): yarn upgrade * v1.11.2-alpha.4 * fix(build): exports modules correctly This was broken, visible, and closes SortableJS#1891.
Fix/no modules
* Create composer.json * Change project name in composer.json * Fix authors listed in composer.json * Update repo source in composer.json Co-authored-by: Wayne Van Son <[email protected]> * Update "issues" link in composer.json Co-authored-by: Wayne Van Son <[email protected]> * Update homepage link in composer.json Co-authored-by: Wayne Van Son <[email protected]> * Update package name in composer.json Co-authored-by: Wayne Van Son <[email protected]> * Remove legacy file from composer.json files list Co-authored-by: Derek DeRaps <[email protected]> Co-authored-by: Wayne Van Son <[email protected]>
Fix IE11 "SCRIPT16389: Unspecified error." when dragging element Could not pull in SortableJS#1904 due to merge errors, so this PR was created instead.
fix: (IE11 "SCRIPT16389)
Update some minor typos
Fix demo link
@waynevanson renamed the repo form `Sortable` to `sortablejs` so users don't get confused on which package to install
Removed Dead Link
|
I've tested this and it works. |
|
Giving this a nudge. It would be great if @RubaXa, @owen-m1, @waynevanson, or one of the other core people signed off on this so we can get this fixed in the next version of Sortable. Thanks! |
|
Just tested with Sortable 1.13.0 and while a similar issue has been fixed, it looks like this one has not. |
|
@jjeff Yes I am still looking at this one... it isn't an issue as it is the intended to only work for the last in the list, but I will add this one for the next version |
Thanks @owen-m1! FWIW, here is the original issue with a GIF animation illustrating the problem. |
|
@ChaituVR Would you like to rebase this or redo this PR with the current master branch? A lot of commits were rolled back. Or I could just copy and paste your code and add it myself if you are okay with that |
|
nvm, it requires some modifications so I will do it |
|
Added in this commit: 77e0481 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1942
When child elements are aligned to the center or to right or to the end, unable to drop the element to start
previously we only have the ability to add only to the last element or nearby element,
with this PR user can add before the first element also
Issue: https://codepen.io/jjeff/pen/PozoJVQ
Fix: https://codepen.io/ChaituVR/pen/wvWbMXB