Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

History Listener Suggestion #13

Closed
ColinCren opened this issue Aug 19, 2014 · 4 comments
Closed

History Listener Suggestion #13

ColinCren opened this issue Aug 19, 2014 · 4 comments

Comments

@ColinCren
Copy link

I love the new History Listener. Its a great addition.

My tool is largely powered by a property grid so just having it say "Edit Property" isn't as useful as saying which one was edited ala Photoshop.

I'd love to see PropertyEditorControlContext have its transaction names be more specific like:

String.Format("{0} {1}", "Edit".Localize(), m_descriptor.DisplayName));
@ColinCren
Copy link
Author

Just realized the context menu might be another similar case.

@Ron2
Copy link
Member

Ron2 commented Aug 19, 2014

I'm glad that the History Lister is proving useful!

That's a great suggestion about the undo/redo command names when editing properties. I'll get that change in soon.

What do you mean by the "context menu might be another similar case"? What commands on which context menu are you referring to?

@ColinCren
Copy link
Author

Sorry, that was WAY too vague haha!

I meant PropertyEditingCommands, but I wouldn't be surprised if other classes derived from IContextMenuCommandProvider like GroupingCommands.cs would also benefit from it. I've only used the PropertyEditingCommands at this point.

Ron2 added a commit that referenced this issue Aug 20, 2014
PropertyEditorControlContext: when editing a property, the property's
name is now included in the undo/redo command's name. #13
PropertyEditingCommands: made the undo/redo text include the property's
name. #13
PropertyGridView: made Pick() be public instead of private. #12
@Ron2
Copy link
Member

Ron2 commented Aug 20, 2014

Thanks, Colin, for the good suggestions.

@Ron2 Ron2 closed this as completed Aug 20, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants