Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Keyboard] Keychron K3 RGB ISO : add k3 keyboard on sn32_develop #341

Closed
wants to merge 5 commits into from

Conversation

seyahdoo
Copy link

Added k3 settings on sn32_develop to be able to test the new code

Description

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

  • None

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

keyboards/keychron/k3/rgb/config.h Outdated Show resolved Hide resolved
keyboards/keychron/k3/rgb/config.h Outdated Show resolved Hide resolved
@dexter93 dexter93 changed the title add k3 keyboard on sn32_develop [Keyboard] Keychron K3 RGB ISO : add k3 keyboard on sn32_develop Aug 5, 2023
@dexter93
Copy link

dexter93 commented Aug 7, 2023

linting keychron/k3/rgb/optical_iso
☒ keychron/k3/rgb/optical_iso: Can't find default keymap.
☒ Lint check failed for: keychron/k3/rgb/optical_iso

@github-actions
Copy link

Thank you for your contribution!
This pull request has been automatically marked as stale because it has not had activity in the last 45 days. It will be closed in 30 days if no further activity occurs. Please feel free to give a status update now, or re-open when it's ready.
For maintainers: Please label with bug, awaiting review, breaking_change, in progress, or on hold to prevent the issue from being re-flagged.

@github-actions github-actions bot added the stale label Sep 22, 2023
@github-actions
Copy link

Thank you for your contribution!
This pull request has been automatically closed because it has not had activity in the last 30 days. Please feel free to give a status update now, ping for review, or re-open when it's ready.
// [stale-action-closed]

@github-actions github-actions bot closed this Oct 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants