Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(github-token): add more details about the required permissions #1008

Merged
merged 2 commits into from
Mar 2, 2023

Conversation

C0ZEN
Copy link
Member

@C0ZEN C0ZEN commented Mar 2, 2023

PR Checklist

Please check if your PR fulfils the following requirements:

  • The commit message follows our guidelines
  • Tests for the changes have been added/updated (for bugfix/feature)
  • Docs have been added/updated (for bugfix/feature)
  • Contributing implementation have been added/updated (for bugfix/feature)
  • Website documentation have been added/updated (for bugfix/feature)

PR Type

What kind of change does this PR introduce?

  • Feature (a new feature)
  • Bugfix (a bug fix)
  • Style (changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc))
  • Refactor (a code change that neither fixes a bug nor adds a feature)
  • Perf (a code change that improves performance)
  • Test (adding missing tests or correcting existing tests)
  • Build (changes that affect the build system, CI configuration or external dependencies)
  • Docs (changes that affect the documentation)
  • Chore (anything else), please describe:

What is the current behaviour?

What is the new behaviour?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

Closes #1006.

@C0ZEN C0ZEN self-assigned this Mar 2, 2023
@Sonia-corporation-bot Sonia-corporation-bot added documentation 📚 Improvements or additions to documentation website 💻 Improvements or additions to website labels Mar 2, 2023
@vercel
Copy link

vercel bot commented Mar 2, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
stale-docs ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Mar 2, 2023 at 10:07PM (UTC)

@codeclimate
Copy link

codeclimate bot commented Mar 2, 2023

Code Climate has analyzed commit fa002fa and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (90% is the threshold).

This pull request will bring the total coverage in the repository to 99.7%.

View more on Code Climate.

@codecov
Copy link

codecov bot commented Mar 2, 2023

Codecov Report

Merging #1008 (fa002fa) into develop (e3b7469) will increase coverage by 0.25%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #1008      +/-   ##
===========================================
+ Coverage    99.26%   99.52%   +0.25%     
===========================================
  Files          131      130       -1     
  Lines         3259     3137     -122     
  Branches       344      321      -23     
===========================================
- Hits          3235     3122     -113     
+ Misses          22       14       -8     
+ Partials         2        1       -1     
Flag Coverage Δ
integration-issues ?
integration-pull-requests 75.67% <ø> (ø)
unit 99.69% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/core/processing/issues/issue-processor.ts 95.65% <0.00%> (-4.35%) ⬇️
tests/utils/fake-issues-processor.ts

@C0ZEN C0ZEN changed the title docs(typo): add missing plural on "pull request" docs(github-token): add more details about the required permissions Mar 2, 2023
@C0ZEN C0ZEN merged commit 05055f8 into develop Mar 2, 2023
@C0ZEN C0ZEN deleted the docs/github-token-permissions branch March 2, 2023 22:15
@Sonia-corporation-bot
Copy link
Contributor

🎉 This PR is included in version 2.5.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@Sonia-corporation-bot Sonia-corporation-bot added the released 📦 Added when a Github/npm release was made label Mar 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation 📚 Improvements or additions to documentation released 📦 Added when a Github/npm release was made website 💻 Improvements or additions to website
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[DOCS] Specify actual permissions needed by GitHub token
2 participants