Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOCS] Specify actual permissions needed by GitHub token #1006

Closed
jvassbo opened this issue Mar 2, 2023 · 4 comments · Fixed by #1008
Closed

[DOCS] Specify actual permissions needed by GitHub token #1006

jvassbo opened this issue Mar 2, 2023 · 4 comments · Fixed by #1008
Assignees
Labels
docs-request 📚 Contains a new documentation improvement request released 📦 Added when a Github/npm release was made

Comments

@jvassbo
Copy link

jvassbo commented Mar 2, 2023

Is your documentation request related to a problem? Please describe.
The token doc page says "make sure to give the proper permissions to your GitHub token", but doesn't specify which permissions these are. By my experimentation pull-request: write is not enough to make this action close or convert stale PRs to drafts.

Describe the solution you'd like
In order to supply the action with a Principle of Least Privilege token, it would be very helpful to know what permissions are expected, and why.

@jvassbo jvassbo added the docs-request 📚 Contains a new documentation improvement request label Mar 2, 2023
@Sonia-corporation-bot
Copy link
Contributor

Hello and thank you for your first contribution!

All contributions are welcome, just keep in mind following the contributing guidelines and to always respect the code of conduct!

Thank you!

Your @Sonia-corporation-bot 🚀

@jvassbo
Copy link
Author

jvassbo commented Mar 2, 2023

By using trail-and-error I was able to pinpoint which permissions are needed (to work on PRs) in my workflow, in case anyone stumbles upon this issue:

permissions:
  contents: read
  pull-requests: write
  repository-projects: read

@C0ZEN C0ZEN self-assigned this Mar 2, 2023
@C0ZEN
Copy link
Member

C0ZEN commented Mar 2, 2023

@jvassbo thank you, I will look into it and update the docs accordingly.

@Sonia-corporation-bot
Copy link
Contributor

🎉 This issue has been resolved in version 2.5.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@Sonia-corporation-bot Sonia-corporation-bot added the released 📦 Added when a Github/npm release was made label Mar 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs-request 📚 Contains a new documentation improvement request released 📦 Added when a Github/npm release was made
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants