Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update minimum supported SQ version to 7.9 #168

Merged
merged 1 commit into from
Nov 17, 2021
Merged

Update minimum supported SQ version to 7.9 #168

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,10 @@ The latest release version (v2.0) is available [here](https://github.com/SonarSo
### Compatibility
v1.0 of the SDK generates plugins that are compatible with SonarQube v4.5.2 -> v6.7.

v2.0 generates plugins that are compatible versions of SonarQube from v6.7 (tested with the current latest available version, v7.3alpha1).
v2.0 generates plugins that are compatible with versions of SonarQube from v6.7 (tested with the current latest available version, v7.3alpha1).

v3.0 generates plugins that are compatible with versions of SonarQube from v7.9.6 (tested with the current latest available version, v9.1).


If you have an existing plugin that was generated with v1.0 of the SDK and want to use the plugin with SonarQube 7.0 or later, you will need to create a new plugin using v2.0 of the SDK. If you customized the _SQALE.xml_ file for your v1.0 plugin, you will need to move the remediation information to the _rules.xml_ file for the v2.0 plugin.

Expand Down
Binary file renamed ...r-roslyn-sdk-template-plugin-1.2.0.73.jar → ...r-roslyn-sdk-template-plugin-1.2.0.76.jar
View file
Open in desktop
Binary file not shown.
2 changes: 1 addition & 1 deletion RoslynPluginGenerator/RoslynPluginJarBuilder.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ public class RoslynPluginJarBuilder
/// <summary>
/// Name of the embedded resource that contains the .jar file to update
/// </summary>
private const string TemplateJarResourceName = "SonarQube.Plugins.Roslyn.Resources.sonar-roslyn-sdk-template-plugin-1.2.0.73.jar";
private const string TemplateJarResourceName = "SonarQube.Plugins.Roslyn.Resources.sonar-roslyn-sdk-template-plugin-1.2.0.76.jar";

// Locations in the jar archive where various file should be embedded.
// Using forward-slash since that is the separator used by Java for archive entry names.
Expand Down
6 changes: 3 additions & 3 deletions RoslynPluginGenerator/SonarQube.Plugins.Roslyn.PluginGenerator.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,10 +54,10 @@

<ItemGroup Label="Embedded jar file">
<!-- Corresponsds to the following commit:
https://github.com/SonarSource/sonarqube-roslyn-sdk-template-plugin/commit/d5788cf9c2bd666fb95f12ee939e848d5dd0fb76

https://github.com/SonarSource/sonarqube-roslyn-sdk-template-plugin/commit/6e4dd88878f40a44231365494db768a7af3e6096
-->
<EmbeddedResource Include="Resources\sonar-roslyn-sdk-template-plugin-1.2.0.73.jar" />
<EmbeddedResource Include="Resources\sonar-roslyn-sdk-template-plugin-1.2.0.76.jar" />
</ItemGroup>

<ItemGroup>
Expand Down
4 changes: 2 additions & 2 deletions RoslynPluginGenerator/UIResources.Designer.cs
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion RoslynPluginGenerator/UIResources.resx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -260,7 +260,7 @@ The conflict will be ignored.</value>
<value>Maximum supported Roslyn version:</value>
</data>
<data name="Program_SupportedSonarQubeVersions" xml:space="preserve">
<value>Minimum supported SonarQube version: 6.7 (highest version tested against: 7.3-alpha1)</value>
<value>Minimum supported SonarQube version: 7.9.6 (highest version tested against: 9.1)</value>
</data>
<data name="RuleGen_DuplicateKey" xml:space="preserve">
<value>Skipping rule in analyzer {0}: Duplicate key.</value>
Expand Down
2 changes: 1 addition & 1 deletion Tests/IntegrationTests/Roslyn/RoslynGenTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -402,7 +402,7 @@ private static void AssertPackagePropertiesInManifest(IPackage package, JarManif

private static void AssertFixedValuesInManifest(JarManifestReader reader)
{
reader.FindValue("Sonar-Version").Should().Be("6.7");
reader.FindValue("Sonar-Version").Should().Be("7.9");
reader.FindValue("Plugin-Class").Should().Be("org.sonar.plugins.roslynsdk.RoslynSdkGeneratedPlugin");
reader.FindValue("SonarLint-Supported").Should().Be("false");
reader.FindValue("Plugin-Dependencies").Should().Be("META-INF/lib/jsr305-1.3.9.jar META-INF/lib/commons-io-2.6.jar META-INF/lib/stax2-api-3.1.4.jar META-INF/lib/staxmate-2.0.1.jar META-INF/lib/stax-api-1.0.1.jar");
Expand Down