SLI-1826 Hint resolved issues on Current File Tab #1298
Conversation
eray-felek-sonarsource
force-pushed
the
feature/ef/SLI-1826-hint-resolved-issues
branch
from
3d4e6c5 to
16e049b
Compare
|
| @@ -73,6 +83,18 @@ class TreeSummary(private val project: Project, private val treeContentKind: Tre | |||
| return "No ${treeContentKind.displayName}s to display" | |||
| } | |||
|
|
|||
| private fun computeEmptyTextForFiltered(newCodePeriod: String): String { | |||
There was a problem hiding this comment.
I would only keep computeEmptyText to handle every cases
| @@ -29,6 +29,16 @@ class TreeSummary(private val project: Project, private val treeContentKind: Tre | |||
| var text: String = emptyText | |||
| private set | |||
|
|
|||
| fun refresh(filesCount: Int, findingsCount: Int, areThereFilteredIssues: Boolean) { | |||
There was a problem hiding this comment.
Instead of duplicating all the code of this method, you can can fallback the other refresh to this one, with parameter to false
| @@ -143,7 +144,10 @@ private int setFileIssues(VirtualFile file, Iterable<LiveIssue> issues) { | |||
| } | |||
|
|
|||
| var filtered = filter(issues); | |||
| var nonFiltered = StreamSupport.stream(issues.spliterator(), false).toList(); | |||
There was a problem hiding this comment.
I think modifying the Iterable to a list is a bit heavy, probably you can call hasNext on the iterator to check whether it's empty or not
There was a problem hiding this comment.
Can also be moved inside the if condition
| @@ -73,6 +73,7 @@ public class IssueTreeModelBuilder implements FindingTreeModelBuilder { | |||
| private boolean includeLocallyResolvedIssues = false; | |||
| private Map<VirtualFile, Collection<LiveIssue>> latestIssues; | |||
| private TreeSummary treeSummary; | |||
| private boolean areThereFilteredIssues; | |||
There was a problem hiding this comment.
I'd probably rename it to hasFilteredIssues for example
SLI-1826