Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SLCORE-1055 sentry integration #1188

Merged
merged 1 commit into from
Dec 23, 2024
Merged

SLCORE-1055 sentry integration #1188

merged 1 commit into from
Dec 23, 2024

Conversation

sophio-japharidze-sonarsource
Copy link
Contributor

@sophio-japharidze-sonarsource sophio-japharidze-sonarsource commented Dec 10, 2024 •
edited by jira bot
Loading

@sophio-japharidze-sonarsource sophio-japharidze-sonarsource force-pushed the SLCORE-1055_sentry_integration branch 7 times, most recently from 32d4919 to d78da9c Compare December 13, 2024 15:10
@jblievremont jblievremont force-pushed the SLCORE-1055_sentry_integration branch 2 times, most recently from 1765d96 to 3cd6bf8 Compare December 19, 2024 14:22
@sophio-japharidze-sonarsource sophio-japharidze-sonarsource marked this pull request as ready for review December 20, 2024 10:01
@sophio-japharidze-sonarsource sophio-japharidze-sonarsource mentioned this pull request Dec 20, 2024
Closed
@jblievremont jblievremont force-pushed the SLCORE-1055_sentry_integration branch from d78da9c to 0c92aef Compare December 20, 2024 10:32
kirill-knize-sonarsource
kirill-knize-sonarsource requested changes Dec 23, 2024
View reviewed changes
Copy link
Contributor

@kirill-knize-sonarsource kirill-knize-sonarsource left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some problems with package-info files. The rest looks good.

@sophio-japharidze-sonarsource sophio-japharidze-sonarsource force-pushed the SLCORE-1055_sentry_integration branch 2 times, most recently from c1281fc to 4ad99a1 Compare December 23, 2024 13:38
@sonarqube-next SonarQube-Next
Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
1 Fixed issue
1 Accepted issue

Measures
0 Security Hotspots
89.2% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube

kirill-knize-sonarsource
kirill-knize-sonarsource approved these changes Dec 23, 2024
View reviewed changes
Copy link
Contributor

@kirill-knize-sonarsource kirill-knize-sonarsource left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sophio-japharidze-sonarsource sophio-japharidze-sonarsource merged commit 5dea422 into master Dec 23, 2024
13 checks passed
@sophio-japharidze-sonarsource sophio-japharidze-sonarsource deleted the SLCORE-1055_sentry_integration branch December 23, 2024 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kirill-knize-sonarsource kirill-knize-sonarsource kirill-knize-sonarsource approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sophio-japharidze-sonarsource @kirill-knize-sonarsource