sonar-checkstyle 4.20 #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ganncamp
requested changes
May 14, 2019
checkstyle.properties
Outdated
| 4.20.date=2019-05-14 | ||
| 4.20.changelogUrl=https://github.com/checkstyle/sonar-checkstyle/releases/tag/4.20 | ||
| 4.20.downloadUrl=https://github.com/checkstyle/sonar-checkstyle/releases/download/4.20/checkstyle-sonar-plugin-4.20.jar | ||
|
|
||
| 4.19.description=Upgrade to Checkstyle 8.19 | ||
| 4.19.sqVersions=[6.7,LATEST] |
There was a problem hiding this comment.
Only one version can be compatible with LATEST
There was a problem hiding this comment.
thank you, changed :)
checkstyle.properties
Outdated
| 4.19.description=Upgrade to Checkstyle 8.19 | ||
| 4.19.sqVersions=[6.7,LATEST] | ||
| 4.19.date=2019-04-29 | ||
| 4.19.changelogUrl=https://github.com/checkstyle/sonar-checkstyle/releases/tag/4.19 | ||
| 4.19.downloadUrl=https://github.com/checkstyle/sonar-checkstyle/releases/download/4.19/checkstyle-sonar-plugin-4.19.jar | ||
|
|
||
| 4.18.description=Upgrade to Checkstyle 8.18 | ||
| 4.18.sqVersions=[6.7,7.6+] | ||
| 4.18.sqVersions=[6.7,7.7+] |
There was a problem hiding this comment.
No point in this update. If there were, you'd use a * instead of a +. But archived compatibility is used only for helping users upgrade from these archived versions. By practice and convention this ending range would stay set to the SQ version that was current when this plugin version was archived.
There was a problem hiding this comment.
ok, good to know! i have reverted this change
ganncamp
approved these changes
May 15, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.