Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SCANMAVEN-220: Enable sonar.scanner.scanAll by default #219

Merged

Conversation

ADarko22
Copy link
Contributor

Please be aware that we are not actively looking for feature contributions. The truth is that it's extremely difficult for someone outside SonarSource to comply with our roadmap and expectations. Therefore, we typically only accept minor cosmetic changes and typo fixes. If you would like to see a new feature, please create a new thread in the forum "Suggest new features".

With that in mind, if you would like to submit a code contribution, make sure that you adhere to the following guidelines and all tests are passing:

  • Please explain your motives to contribute this change: what problem you are trying to fix, what improvement you are trying to make
  • Use the following formatting style: SonarSource/sonar-developer-toolset
  • Provide a unit test for any code you changed
  • If there is a JIRA ticket available, please make your commits and pull request start with the ticket ID (MSONAR-XXXX)

We will try to give you feedback on your contribution as quickly as possible.

Thank You!
The SonarSource Team

Copy link
Contributor

@leveretka leveretka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A minor suggestion, otherwise looks good too me!

src/it/README.md Outdated Show resolved Hide resolved
@ADarko22 ADarko22 force-pushed the angelo/SCANMAVEN-220_sonar_scanner_scanAll_default_to_true branch from 2c7399d to 284a6fd Compare May 14, 2024 14:56
@ADarko22 ADarko22 force-pushed the angelo/SCANMAVEN-220_sonar_scanner_scanAll_default_to_true branch from 284a6fd to 43898a3 Compare May 14, 2024 14:56
@ADarko22 ADarko22 merged commit 990c59d into master May 14, 2024
3 of 17 checks passed
@ADarko22 ADarko22 deleted the angelo/SCANMAVEN-220_sonar_scanner_scanAll_default_to_true branch May 14, 2024 15:01
ADarko22 added a commit that referenced this pull request May 28, 2024
…y default (#219)". To be delivered in a future version

This reverts commit 990c59d
ADarko22 added a commit that referenced this pull request May 28, 2024
…y default (#219)". To be delivered in a future version.

This reverts commit 990c59d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants