Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix gradle project convention deprecation #272

Conversation

patrick-dedication
Copy link

@patrick-dedication patrick-dedication commented Nov 23, 2024

  • this is deprecated since gradle 7.1 and will be removed with gradle 9 see here
  • this holds my company from using org.gradle.warning.mode=fail

I see a TODO here which leads me to belive you might still want to support gradle < 7.1.
Edit: This is not true (Couldn't find out if that still holds true, if so this can't be merged.)
Otherwise I'm happy create additional PRs to fix the two TODOs associated with backwards compatibility.
If you create an Issue I'm happy to update the PR and commit message to reflect it.

Note:
As far as I can tell File SonarPropertyComputer has some lines that don't comply with your formatting settings from SonarSource/sonar-developer-toolset.
I could create an additional PR to fix that if thats ok with you.

@patrick-dedication patrick-dedication force-pushed the patrick-dedication/fix-gradle-project-convention-deprecation branch from a9b6c71 to cf1697f Compare November 29, 2024 06:20
Copy link

github-actions bot commented Dec 7, 2024

This PR is stale because it has been open 7 days with no activity. If there is no activity in the next 7 days it will be closed automatically

@github-actions github-actions bot added the stale label Dec 7, 2024
@jjohannes
Copy link

I just discovered this. I would appreciate this update to get rid of the deprecation warnings and to be prepared for Gradle 9.

Comment on backward compatibility: The changes in this PR do not break compatibility with Gradle 5 / 6 / 7. JavaPluginExtension exists and can be used since Gradle 4.10. Only the deprecation for JavaPluginConvention was added in 7.1.

@github-actions github-actions bot removed the stale label Dec 10, 2024
@patrick-dedication
Copy link
Author

patrick-dedication commented Dec 10, 2024

Ah the master himself ❤️.
Thanks for clarifying!
Seems this repo is dead, I've also looked for ways to get in touch with the community but didn't find a Slack or so.
The only thing that I think might be worth is creating an issue in their backlog.

@jjohannes I wrote you a mail on 27.11., to the mail on your onepiece.software address. Maybe write me a mail to [email protected] so we can get in touch

@jjohannes
Copy link

@patrick-dedication dropped you a mail just yesterday. :)

The issue tracker for this project is here:
https://sonarsource.atlassian.net/jira/software/c/projects/SCANGRADLE/issues
Maybe you can also open an issue for the deprecations there and link this PR.

@patrick-dedication
Copy link
Author

Seems I can't create an issue. Neither as guest nor when logged in.

Copy link

This PR is stale because it has been open 7 days with no activity. If there is no activity in the next 7 days it will be closed automatically

@github-actions github-actions bot added the stale label Dec 18, 2024
* this is deprecated since gradle 7.1 and will be removed with gradle 9
@patrick-dedication patrick-dedication force-pushed the patrick-dedication/fix-gradle-project-convention-deprecation branch from cf1697f to fe3cc14 Compare December 18, 2024 05:06
@patrick-dedication
Copy link
Author

Created a forum post

@stefanroeck
Copy link

Cool, we need this, too. Any chance to get this PR merged?

@dorian-burihabwa-sonarsource
Copy link
Contributor

Hey @patrick-dedication,
Thank you for opening this PR. This issue has been our radar for a little while now and your PR confirms that the need for this change is growing stronger. Unfurtonately, because this breaks the CI, this might require a bit more work to pass across the array of settings we test in (include Gradle 6).
I will get back to the team to discuss the problem and we will keep you updated on the solution we settle on.

Cheers,

Dorian

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants