-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix gradle project convention deprecation #272
Fix gradle project convention deprecation #272
Conversation
a9b6c71
to
cf1697f
Compare
This PR is stale because it has been open 7 days with no activity. If there is no activity in the next 7 days it will be closed automatically |
I just discovered this. I would appreciate this update to get rid of the deprecation warnings and to be prepared for Gradle 9. Comment on backward compatibility: The changes in this PR do not break compatibility with Gradle 5 / 6 / 7. |
Ah the master himself ❤️. @jjohannes I wrote you a mail on 27.11., to the mail on your onepiece.software address. Maybe write me a mail to [email protected] so we can get in touch |
@patrick-dedication dropped you a mail just yesterday. :) The issue tracker for this project is here: |
Seems I can't create an issue. Neither as guest nor when logged in. |
This PR is stale because it has been open 7 days with no activity. If there is no activity in the next 7 days it will be closed automatically |
* this is deprecated since gradle 7.1 and will be removed with gradle 9
cf1697f
to
fe3cc14
Compare
Created a forum post |
Cool, we need this, too. Any chance to get this PR merged? |
Quality Gate passedIssues Measures |
Hey @patrick-dedication, Cheers, Dorian |
org.gradle.warning.mode=fail
I see a TODO here which leads me to belive you might still want to support gradle < 7.1.
Edit: This is not true (Couldn't find out if that still holds true, if so this can't be merged.)
Otherwise I'm happy create additional PRs to fix the two TODOs associated with backwards compatibility.
If you create an Issue I'm happy to update the PR and commit message to reflect it.
Note:
As far as I can tell File SonarPropertyComputer has some lines that don't comply with your formatting settings from SonarSource/sonar-developer-toolset.
I could create an additional PR to fix that if thats ok with you.