SCANGRADLE-178 increase android sdk to be compatible with android gradle 8.3.0 #258
Conversation
hashicorp-vault-sonar-prod
bot
changed the title
|
There was a problem hiding this comment.
LGTM, but the title of the PR needs to be changed to match the ticket it refers to because as the current proposal does not test with AGP 8.3.0.
I think the PR should be renamed and the commits split in two parts with the first bumping the SDK version of the test projects and the second re-enabling the tests with AGP 7.1.0 and Gradle 7.5.1 (both commits can refer to the same ticket).
| - GRADLE_VERSION: 7.5.1 | ||
| ANDROID_GRADLE_VERSION: 7.1.0 |
There was a problem hiding this comment.
Consider re-enabling that configuration as part of a separate commit
There was a problem hiding this comment.
I think it is a good idea, I thought about splitting but was a bit too lazy. 👍
SCANGRADLE-178
The SonarSource Team