Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SONARPHP-1477 Support on-demand plugin downloading #1157

Merged
merged 2 commits into from
Nov 6, 2023
Merged

SONARPHP-1477 Support on-demand plugin downloading #1157

merged 2 commits into from
Nov 6, 2023

Conversation

nils-werner-sonarsource
Copy link
Contributor

No description provided.

@sonarqube-next SonarQube-Next
Copy link

sonarqube-next bot commented Nov 1, 2023

Quality Gate passed Quality Gate passed

Kudos, no new issues are introduced in this PR!

0 New issues
0 Security Hotspots
No Coverage information No data about Coverage
No Duplication information No data about Duplication

See analysis details on SonarQube

jonas-wielage-sonarsource
jonas-wielage-sonarsource approved these changes Nov 6, 2023
View reviewed changes
Copy link
Contributor

@jonas-wielage-sonarsource jonas-wielage-sonarsource left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Why plugin api 9.13? Is the requiredForLanguages introduced there?
Also, does this PR need to be merged simultaneously with another PR in security, or is everything set there?

@nils-werner-sonarsource
Copy link
Contributor Author

LGTM. Why plugin API 9.13? Is the requiredForLanguages introduced there? Also, does this PR need to be merged simultaneously with another PR in security, or is everything set there?

The requiredForLanguages is part of the Maven packaging plugin. But the plugin uses the LTS version. And security is already released and deployed with the feature.

@nils-werner-sonarsource nils-werner-sonarsource merged commit 0f710ff into master Nov 6, 2023
@nils-werner-sonarsource nils-werner-sonarsource deleted the SONARPHP-1477 branch November 6, 2023 13:12
@froque froque mentioned this pull request Sep 21, 2024
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonas-wielage-sonarsource jonas-wielage-sonarsource jonas-wielage-sonarsource approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nils-werner-sonarsource @jonas-wielage-sonarsource