Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SONARKT-592 Remove K1 #573

Merged
merged 2 commits into from
Mar 3, 2025
Merged

SONARKT-592 Remove K1 #573

merged 2 commits into from
Mar 3, 2025

Conversation

Godin
Copy link
Member

@Godin Godin commented Feb 24, 2025

@Godin Godin force-pushed the godin/removeK1 branch 10 times, most recently from 699e4bb to a994a87 Compare February 28, 2025 14:55
@Godin Godin force-pushed the godin/removeK1 branch 2 times, most recently from b06bc17 to f035130 Compare March 3, 2025 10:04
@Godin Godin marked this pull request as ready for review March 3, 2025 13:35
@Godin Godin requested a review from Copilot March 3, 2025 13:35

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Overview

This pull request removes legacy code related to K1 internals as part of the SONARKT-592 effort. The deprecated module provider and K1 internals are entirely removed from the codebase.

  • Removed KtModuleProviderByCompilerConfiguration.java
  • Removed K1internals.java

Reviewed Changes

File Description
sonar-kotlin-api/src/main/java/org/sonarsource/kotlin/api/frontend/KtModuleProviderByCompilerConfiguration.java Removal of deprecated module provider using CompilerConfiguration
sonar-kotlin-api/src/main/java/org/sonarsource/kotlin/api/frontend/K1internals.java Removal of legacy K1 internals

Copilot reviewed 43 out of 43 changed files in this pull request and generated no comments.

@Godin Godin requested a review from leveretka March 3, 2025 13:35
Copy link
Contributor

@leveretka leveretka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

The minimization will be in a separate PR?

@Godin Godin merged commit 5b94399 into master Mar 3, 2025
15 checks passed
@Godin Godin deleted the godin/removeK1 branch March 3, 2025 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants