SONARKT-388 Fix IllegalArgumentException in CollectionShouldBeImmutab…

…leCheck
SonarSource · Oct 25, 2024 · 3efe09b · 3efe09b
1 parent 5770f81
commit 3efe09b
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 2 deletions.
diff --git a/kotlin-checks-test-sources/src/main/kotlin/checks/CollectionShouldBeImmutableCheckSample.kt b/kotlin-checks-test-sources/src/main/kotlin/checks/CollectionShouldBeImmutableCheckSample.kt
@@ -249,4 +249,7 @@ class CollectionShouldBeImmutableCheckSample {
 
 private fun nonCompliantParameterOnFileLevel(list: MutableList<Int>): Int { // Noncompliant
     return list.reduce { acc, it -> acc + it}
-}
+}
+
+// https://sonarsource.atlassian.net/browse/SONARKT-388
+private fun <T> intersectionType(t: T) = if (t is String) listOf(t) else emptyList()
diff --git a/...in-checks/src/main/java/org/sonarsource/kotlin/checks/CollectionShouldBeImmutableCheck.kt b/...in-checks/src/main/java/org/sonarsource/kotlin/checks/CollectionShouldBeImmutableCheck.kt
@@ -153,7 +153,10 @@ class CollectionShouldBeImmutableCheck : AbstractCheck() {
                 val functionDescriptor = call.getResolvedCall(bindingContext)?.resultingDescriptor
                 val parameterTypes = functionDescriptor?.valueParameters
                 if (parameterTypes != null) {
-                    val fullyQualifiedTypes = parameterTypes.map { it.type.getKotlinTypeFqName(false) }
+                    val fullyQualifiedTypes = parameterTypes.map {
+                        if (it.type.constructor.declarationDescriptor == null) null
+                        else it.type.getKotlinTypeFqName(false)
+                    }
                     call.valueArguments.zip(fullyQualifiedTypes).filter { it.second in mutableCollections }.map { it.first }
                 } else {
                     call.valueArguments