Fix S6966 FP: Don't raise on XmlReader and XmlWriter methods #9364
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zsolt-kolbay-sonarsource
approved these changes
May 30, 2024
| @@ -104,6 +105,10 @@ private static WellKnownExtensionMethodContainer BuildWellKnownExtensionMethodCo | |||
| { | |||
| exclusions.Add(x => x.Is(KnownType.MongoDB_Driver_IMongoCollectionExtensions, "Find")); // https://github.com/SonarSource/sonar-dotnet/issues/9265 | |||
| } | |||
| if (compilation.GetTypeByMetadataName(KnownType.System_Xml_XmlReader) is not null || compilation.GetTypeByMetadataName(KnownType.System_Xml_XmlWriter) is not null) | |||
There was a problem hiding this comment.
This is not needed. Those types are always available and we filter for types rather than methods for this one.
There was a problem hiding this comment.
Oops I forgot this there - I was trying to add the exclusions in this method as it made more sense - but did not work out. :/
| @@ -629,6 +629,7 @@ public sealed partial class KnownType | |||
| public static readonly KnownType System_Xml_XmlUrlResolver = new("System.Xml.XmlUrlResolver"); | |||
| public static readonly KnownType System_Xml_XmlTextReader = new("System.Xml.XmlTextReader"); | |||
| public static readonly KnownType System_Xml_Resolvers_XmlPreloadedResolver = new("System.Xml.Resolvers.XmlPreloadedResolver"); | |||
There was a problem hiding this comment.
CAYC: please move this up so they are sorted alphabetically.
| builder | ||
| .AddReferences(MetadataReferenceFacade.SystemXml) | ||
| .AddSnippet(""" | ||
| using System; |
There was a problem hiding this comment.
This using isn't needed.
|
mary-georgiou-sonarsource
changed the title
|
mary-georgiou-sonarsource
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9336