Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extend UnitTestHelper with IsIgnoredTestMethod #7333

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Extend UnitTestHelper with IsIgnoredTestMethod #7333

wants to merge 2 commits into from

Conversation

Corniel
Copy link
Contributor

@Corniel Corniel commented Jun 2, 2023

As discussed in #6185, some extended unit test detection logic should be centralized.

@Corniel
Copy link
Contributor Author

Corniel commented Jun 2, 2023

@pavel-mikula-sonarsource As this involves changing so three existing rules, I decided to make a small separate PR.

@pavel-mikula-sonarsource pavel-mikula-sonarsource mentioned this pull request Jun 5, 2023
Merged
@Corniel
Copy link
Contributor Author

Corniel commented Jun 5, 2023

@pavel-mikula-sonarsource

What about changing the API to: IsTestMethod(bool includeIgnoredTests: false)?

@Corniel Corniel force-pushed the corniel/test-helper branch from 87ad198 to 757fa0f Compare June 25, 2023 12:48
@Corniel
Copy link
Contributor Author

Corniel commented Jun 25, 2023

@pavel-mikula-sonarsource Any ETA on this?

@Corniel Corniel force-pushed the corniel/test-helper branch from 757fa0f to f963200 Compare July 12, 2023 13:52
@pavel-mikula-sonarsource
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

No commit pushedDate could be found for PR 7333 in repo SonarSource/sonar-dotnet

@pavel-mikula-sonarsource
Copy link
Contributor

I'd keep the API as is. It's not use that often

@pavel-mikula-sonarsource
Copy link
Contributor

I'm sorry, we don't give ETAs in general. And I tend to be pretty busy all the time :)

@pavel-mikula-sonarsource
Copy link
Contributor

There's some infra issue with running CI :/

@pavel-mikula-sonarsource
Copy link
Contributor

Changes looks good, I'll need to run CI to verify the results.

@pavel-mikula-sonarsource
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

No commit pushedDate could be found for PR 7333 in repo SonarSource/sonar-dotnet

@pavel-mikula-sonarsource
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

pavel-mikula-sonarsource
pavel-mikula-sonarsource requested changes Jul 24, 2023
View reviewed changes
Copy link
Contributor

@pavel-mikula-sonarsource pavel-mikula-sonarsource left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We'll need to fix the UTs :)
We did quite some changes on Java ITs - rebase could fix those.
Then I can take care of .NET ITs.

@Corniel Corniel force-pushed the corniel/test-helper branch from 97d0baa to ef93b9f Compare July 30, 2023 06:43
@Corniel
Copy link
Contributor Author

Corniel commented Jul 30, 2023

Did a rebase.

@Corniel Corniel force-pushed the corniel/test-helper branch from ef93b9f to a611283 Compare August 21, 2023 11:20
@Corniel
Copy link
Contributor Author

Corniel commented Aug 21, 2023

Another rebase.

@pavel-mikula-sonarsource
Copy link
Contributor

/azp run

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@Corniel Corniel force-pushed the corniel/test-helper branch from a611283 to 48dd97b Compare March 19, 2024 13:14
@Corniel
Copy link
Contributor Author

Corniel commented Mar 19, 2024

another rebase.

@pavel-mikula-sonarsource
Copy link
Contributor

@Corniel Can you take a look at the UTs? They were failing during the previous run and I haven't seen a change there

@Corniel
Copy link
Contributor Author

Corniel commented Mar 19, 2024

@pavel-mikula-sonarsource The regression-test.ps1 is gone?! Besides that, the setup still requires some environment variables that would not like to configure on my work laptop.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pavel-mikula-sonarsource pavel-mikula-sonarsource pavel-mikula-sonarsource requested changes

Requested changes must be addressed to merge this pull request.

Assignees

@pavel-mikula-sonarsource pavel-mikula-sonarsource

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Corniel @pavel-mikula-sonarsource