S3900: Dummy rule implementation #6917
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zsolt-kolbay-sonarsource
changed the title
zsolt-kolbay-sonarsource
changed the title
github-actions
bot
assigned antonioaversa and Tim-Pohlmann and unassigned zsolt-kolbay-sonarsource and antonioaversa
zsolt-kolbay-sonarsource
changed the title
github-actions
bot
assigned pavel-mikula-sonarsource and unassigned zsolt-kolbay-sonarsource
pavel-mikula-sonarsource
requested changes
Mar 14, 2023
...SonarAnalyzer.CSharp/SymbolicExecution/Roslyn/PublicMethodArgumentsShouldBeCheckedForNull.cs
Outdated
Show resolved
Hide resolved
...ommon/SymbolicExecution/Roslyn/RuleChecks/PublicMethodArgumentsShouldBeCheckedForNullBase.cs
Outdated
Show resolved
Hide resolved
...ommon/SymbolicExecution/Roslyn/RuleChecks/PublicMethodArgumentsShouldBeCheckedForNullBase.cs
Outdated
Show resolved
Hide resolved
...ommon/SymbolicExecution/Roslyn/RuleChecks/PublicMethodArgumentsShouldBeCheckedForNullBase.cs
Outdated
Show resolved
Hide resolved
...Analyzer.UnitTest/Rules/SymbolicExecution/PublicMethodArgumentsShouldBeCheckedForNullTest.cs
Outdated
Show resolved
Hide resolved
...Analyzer.UnitTest/Rules/SymbolicExecution/PublicMethodArgumentsShouldBeCheckedForNullTest.cs
Outdated
Show resolved
Hide resolved
...Analyzer.UnitTest/Rules/SymbolicExecution/PublicMethodArgumentsShouldBeCheckedForNullTest.cs
Outdated
Show resolved
Hide resolved
...Analyzer.UnitTest/Rules/SymbolicExecution/PublicMethodArgumentsShouldBeCheckedForNullTest.cs
Outdated
Show resolved
Hide resolved
github-actions
bot
assigned zsolt-kolbay-sonarsource and unassigned pavel-mikula-sonarsource
pavel-mikula-sonarsource
force-pushed
the
feature/SE
branch
from
659c27c to
5110ec6
Compare
github-actions
bot
assigned pavel-mikula-sonarsource and unassigned zsolt-kolbay-sonarsource
github-actions
bot
assigned zsolt-kolbay-sonarsource and unassigned pavel-mikula-sonarsource
|
Please rebase it and assign it to me for merging. Failing ITs are fine at this stage, as we're introducing dummy version of the rule on a feature branch. |
|
Closing because of mixed merge and rebase. Creating a new PR. |
zsolt-kolbay-sonarsource
force-pushed
the
Zsolt/S3900-dummy-rule-implementation
branch
from
13a380c to
6007831
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
|
SonarCloud Quality Gate failed. |
pavel-mikula-sonarsource
deleted the
Zsolt/S3900-dummy-rule-implementation
branch
pavel-mikula-sonarsource
pushed a commit
that referenced
this pull request
Mar 20, 2023
pavel-mikula-sonarsource
pushed a commit
that referenced
this pull request
Mar 28, 2023
pavel-mikula-sonarsource
pushed a commit
that referenced
this pull request
Mar 31, 2023
pavel-mikula-sonarsource
pushed a commit
that referenced
this pull request
Apr 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #6793
Task 3