-
Notifications
You must be signed in to change notification settings - Fork 229
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Update RSPEC before 9.6 release (#7654)
- Loading branch information
1 parent
14115ea
commit 1366be8
Showing
11 changed files
with
18 additions
and
18 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,6 +1,5 @@ | ||
<h2>Why is this an issue?</h2> | ||
<p>A source file that grows too much tends to aggregate too many responsibilities and inevitably becomes harder to understand and, therefore, to | ||
maintain.</p> | ||
<p>When a source file grows too much, it can accumulate numerous responsibilities and become challenging to understand and maintain.</p> | ||
<p>Above a specific threshold, refactor the file into smaller files whose code focuses on well-defined tasks. Those smaller files will be easier to | ||
understand and easier to test.</p> | ||
understand and test.</p> | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -35,5 +35,5 @@ | |
"2.9.2" | ||
] | ||
}, | ||
"quickfix": "unknown" | ||
"quickfix": "targeted" | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,12 +1,13 @@ | ||
<h2>Why is this an issue?</h2> | ||
<p>Storing a value inside a collection at a given key or index and then unconditionally overwriting it without reading the initial value is a case of | ||
"dead store".</p> | ||
a "dead store".</p> | ||
<pre> | ||
list[index] = "value 1"; | ||
list[index] = "value 2"; // Noncompliant | ||
|
||
dictionary.Add(key, "value 1"); | ||
dictionary[key] = "value 2"; // Noncompliant | ||
</pre> | ||
<p>At best it is redundant and will confuse the reader, most often it is an error and not what the developer intended to do.</p> | ||
<p>This practice is redundant and will cause confusion for the reader. More importantly, it is often an error and not what the developer intended to | ||
do.</p> | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,6 +1,5 @@ | ||
<h2>Why is this an issue?</h2> | ||
<p>A source file that grows too much tends to aggregate too many responsibilities and inevitably becomes harder to understand and, therefore, to | ||
maintain.</p> | ||
<p>When a source file grows too much, it can accumulate numerous responsibilities and become challenging to understand and maintain.</p> | ||
<p>Above a specific threshold, refactor the file into smaller files whose code focuses on well-defined tasks. Those smaller files will be easier to | ||
understand and easier to test.</p> | ||
understand and test.</p> | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -35,5 +35,5 @@ | |
"2.9.2" | ||
] | ||
}, | ||
"quickfix": "partial" | ||
"quickfix": "targeted" | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,9 +1,10 @@ | ||
<h2>Why is this an issue?</h2> | ||
<p>Storing a value inside a collection at a given key or index and then unconditionally overwriting it without reading the initial value is a case of | ||
"dead store".</p> | ||
a "dead store".</p> | ||
<pre> | ||
towns.Item(x) = "London" | ||
towns.Item(x) = "Chicago"; // Noncompliant | ||
</pre> | ||
<p>At best it is redundant and will confuse the reader, most often it is an error and not what the developer intended to do.</p> | ||
<p>This practice is redundant and will cause confusion for the reader. More importantly, it is often an error and not what the developer intended to | ||
do.</p> | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters