SONARIAC-1856 Modify S7019: add EXEC alternatives and exceptions #4597
Conversation
rudy-regazzoni-sonarsource
changed the title
rules/S7019/docker/rule.adoc
Outdated
| [source,docker,diff-id=2,diff-type=noncompliant] | ||
| ---- | ||
| FROM scratch | ||
| ENTRYPOINT echo "Long script with chaining commands" \ | ||
| && echo "Welcome!" \ | ||
| && echo "Goodbye" | ||
| ---- | ||
|
|
||
| [source,docker,diff-id=3,diff-type=noncompliant] | ||
| ---- | ||
| FROM scratch | ||
| ENTRYPOINT echo "Long script with chaining commands" \ | ||
| && echo "Welcome!" \ | ||
| && echo "Goodbye" | ||
| ---- | ||
|
|
There was a problem hiding this comment.
I would remove the diff-id=3 noncompliant example.
Keep only the compliant one with the wrapper script, but add the relation to a non compliant one.
There was a problem hiding this comment.
Ah very good point! I didn't know we could link multiple compliant examples to a single non-compliant one. Way better!
There was a problem hiding this comment.
That's not what I meant, sorry for the confusion.
I meant that diff-id and diff-type will be removed from the wrapper file solution.
Unfortunately we can only use one diff-id per unique example, so I we need to adress this in a follow up PR 😅
Co-authored-by: Jonas Wielage <[email protected]>
…into SONARIAC-1856
|
|
No description provided.