NET-920 Modify rule S125: Add dotnet example #4589
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
+17
to
+25
| void Method(string s) | ||
| { | ||
| // if (s.StartsWith('A')) | ||
| // { | ||
| // s = s.Substring(1); | ||
| // } | ||
|
|
||
| // Do something... | ||
| } |
There was a problem hiding this comment.
I was not really inspired if you have a better idea 😅
There was a problem hiding this comment.
What about (but it's really nitpick):
int CalculateTotal(int[] prices)
{
int total = 0;
foreach (int price in prices)
{
total += price;
}
// int discount = 10;
// total -= discount;
return total;
}There was a problem hiding this comment.
To have some real code in the method, but as I said, very nitpick and optional
sebastien-marichal
force-pushed
the
sma/modify-S125
branch
from
2421816 to
d8af44e
Compare
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NET-920
Part of NET-255
Fixes SonarSource/sonar-dotnet#6062
Review
A dedicated reviewer checked the rule description successfully for: