Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modify rule S2325: Add WinForms and WPF EventHandler exception #4546

Merged
merged 1 commit into from
Nov 28, 2024
Merged

Modify rule S2325: Add WinForms and WPF EventHandler exception #4546

merged 1 commit into from
Nov 28, 2024

Conversation

sebastien-marichal
Copy link
Contributor

Review

A dedicated reviewer checked the rule description successfully for:

  • logical errors and incorrect information
  • information gaps and missing content
  • text style and tone
  • PR summary and labels follow the guidelines

@sonarqube-next SonarQube-Next
Copy link

Quality Gate passed Quality Gate passed for 'rspec-tools'

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

@sonarqube-next SonarQube-Next
Copy link

Quality Gate passed Quality Gate passed for 'rspec-frontend'

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

@sebastien-marichal sebastien-marichal changed the title Modify rule S2325: Add WinForms and WPF EventHandler excpetion Modify rule S2325: Add WinForms and WPF EventHandler exception Nov 28, 2024
Tim-Pohlmann
Tim-Pohlmann approved these changes Nov 28, 2024
View reviewed changes
Copy link
Contributor

@Tim-Pohlmann Tim-Pohlmann left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good except a missing heading.

rules/S2325/csharp/rule.adoc Show resolved Hide resolved
@Tim-Pohlmann Tim-Pohlmann merged commit fef1801 into master Nov 28, 2024
13 checks passed
@Tim-Pohlmann Tim-Pohlmann deleted the sma/modify-s2325 branch November 28, 2024 10:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tim-Pohlmann Tim-Pohlmann Tim-Pohlmann approved these changes

Assignees
No one assigned
Labels
dotnet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sebastien-marichal @Tim-Pohlmann