Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify rule S6721: Fix description (APPSEC-2287) #4535

Merged
merged 3 commits into from
Nov 26, 2024

Conversation

egon-okerman-sonarsource
Copy link
Contributor

Review

A dedicated reviewer checked the rule description successfully for:

  • logical errors and incorrect information
  • information gaps and missing content
  • text style and tone
  • PR summary and labels follow the guidelines

Copy link

Quality Gate passed Quality Gate passed for 'rspec-tools'

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

Copy link

Quality Gate passed Quality Gate passed for 'rspec-frontend'

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

Copy link
Contributor

@loris-s-sonarsource loris-s-sonarsource left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Minor: Removing the part with the small description seems unnecessary

@egon-okerman-sonarsource
Copy link
Contributor Author

I removed it because it could be potentially misleading: webhooks created through Workflows for Microsoft Teams have a different format and we do not detect them. So, saying that webhooks might have different effects depending on permissions is not true in this case.

@loris-s-sonarsource
Copy link
Contributor

LGTM!

@egon-okerman-sonarsource egon-okerman-sonarsource merged commit e0f73e0 into master Nov 26, 2024
11 checks passed
@egon-okerman-sonarsource egon-okerman-sonarsource deleted the rule/S6721-fix-description branch November 26, 2024 09:03
@egon-okerman-sonarsource egon-okerman-sonarsource changed the title Modify rule S6721: Fix description Modify rule S6721: Fix description (APPSEC-2287) Nov 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants