Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create rule S7166: Adobe OAuth credentials should not be disclosed (APPSEC-2237) #4504

Merged
merged 2 commits into from
Dec 17, 2024
Merged

Create rule S7166: Adobe OAuth credentials should not be disclosed (APPSEC-2237) #4504

merged 2 commits into from
Dec 17, 2024

Conversation

github-actions[bot]
Copy link
Contributor

You can preview this rule here (updated a few minutes after each push).

Review

A dedicated reviewer checked the rule description successfully for:

  • logical errors and incorrect information
  • information gaps and missing content
  • text style and tone
  • PR summary and labels follow the guidelines

@pierre-loup-tristant-sonarsource pierre-loup-tristant-sonarsource changed the title Create rule S7166 Create rule S7166: Adobe secrets should not be disclosed (APPSEC-2237) Nov 14, 2024
@pierre-loup-tristant-sonarsource pierre-loup-tristant-sonarsource changed the title Create rule S7166: Adobe secrets should not be disclosed (APPSEC-2237) Create rule S7166: Adobe OAuth credentials should not be disclosed (APPSEC-2237) Nov 15, 2024
@pierre-loup-tristant-sonarsource pierre-loup-tristant-sonarsource marked this pull request as ready for review November 15, 2024 09:00
loris-s-sonarsource
loris-s-sonarsource approved these changes Nov 15, 2024
View reviewed changes
Copy link
Contributor

@loris-s-sonarsource loris-s-sonarsource left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, copypaste typo, I recommend making sure to update the sonar-text PR

rules/S7166/secrets/rule.adoc Outdated Show resolved Hide resolved
@sonarqube-next SonarQube-Next
Copy link

Quality Gate passed Quality Gate passed for 'rspec-tools'

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

@sonarqube-next SonarQube-Next
Copy link

Quality Gate passed Quality Gate passed for 'rspec-frontend'

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

@pierre-loup-tristant-sonarsource pierre-loup-tristant-sonarsource merged commit 5e5c005 into master Dec 17, 2024
9 of 10 checks passed
@pierre-loup-tristant-sonarsource pierre-loup-tristant-sonarsource deleted the rule/add-RSPEC-S7166 branch December 17, 2024 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@loris-s-sonarsource loris-s-sonarsource loris-s-sonarsource approved these changes

Assignees

@pierre-loup-tristant-sonarsource pierre-loup-tristant-sonarsource

Labels
secrets
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@loris-s-sonarsource @pierre-loup-tristant-sonarsource