Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SONARIAC-1789 Align software quality impact and defaultSeverities on IaC Rules #4485

Merged
merged 2 commits into from
Nov 12, 2024

Conversation

jonas-wielage-sonarsource
Copy link
Contributor

Review

A dedicated reviewer checked the rule description successfully for:

  • logical errors and incorrect information
  • information gaps and missing content
  • text style and tone
  • PR summary and labels follow the guidelines

@jonas-wielage-sonarsource jonas-wielage-sonarsource changed the title Update impact and severities Align software quality impact and defaultSeverities on IaC Rules Nov 12, 2024
Copy link
Contributor

@petertrr petertrr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Please see my suggestion. I think S7018, S7020, S7031 should have same impacts

rules/S7018/docker/metadata.json Outdated Show resolved Hide resolved
@jonas-wielage-sonarsource jonas-wielage-sonarsource changed the title Align software quality impact and defaultSeverities on IaC Rules SONARIAC-1789 Align software quality impact and defaultSeverities on IaC Rules Nov 12, 2024
Copy link

Quality Gate passed Quality Gate passed for 'rspec-tools'

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

Copy link

Quality Gate passed Quality Gate passed for 'rspec-frontend'

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

@jonas-wielage-sonarsource jonas-wielage-sonarsource merged commit d870aef into master Nov 12, 2024
8 of 9 checks passed
@jonas-wielage-sonarsource jonas-wielage-sonarsource deleted the jonas/update-severities branch November 12, 2024 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants