Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create rule S7132 std::string_view::data() should not be passed to API expecting C-style strings CPP-5820 #4448

Merged
merged 8 commits into from
Nov 12, 2024
Merged

Create rule S7132 std::string_view::data() should not be passed to API expecting C-style strings CPP-5820 #4448

merged 8 commits into from
Nov 12, 2024

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Oct 29, 2024 •
edited by loic-joly-sonarsource
Loading

You can preview this rule here (updated a few minutes after each push).

CPP-5820

@github-actions github-actions bot added the cfamily C / C++ / Objective-C label Oct 29, 2024
@loic-joly-sonarsource loic-joly-sonarsource changed the title Create rule S7132 Create rule S7132 std::string_view::data() should not be passed to API expecting C-string CPP-5820 Oct 29, 2024
@loic-joly-sonarsource loic-joly-sonarsource changed the title Create rule S7132 std::string_view::data() should not be passed to API expecting C-string CPP-5820 Create rule S7132 std::string_view::data() should not be passed to API expecting C-style strings CPP-5820 Oct 29, 2024
@loic-joly-sonarsource loic-joly-sonarsource marked this pull request as ready for review October 29, 2024 21:49
tomasz-kaminski-sonarsource
tomasz-kaminski-sonarsource requested changes Oct 30, 2024
View reviewed changes
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would add links to related rules, S7121 and S7118.

@sonarqube-next SonarQube-Next
Copy link

sonarqube-next bot commented Nov 1, 2024

Quality Gate passed Quality Gate passed for 'rspec-tools'

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

@sonarqube-next SonarQube-Next
Copy link

sonarqube-next bot commented Nov 1, 2024

Quality Gate passed Quality Gate passed for 'rspec-frontend'

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

@sonarqube-next SonarQube-Next
Copy link

Quality Gate passed Quality Gate passed for 'rspec-tools'

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

@sonarqube-next SonarQube-Next
Copy link

Quality Gate passed Quality Gate passed for 'rspec-frontend'

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

@tomasz-kaminski-sonarsource tomasz-kaminski-sonarsource merged commit 78497b8 into master Nov 12, 2024
8 of 10 checks passed
@tomasz-kaminski-sonarsource tomasz-kaminski-sonarsource deleted the rule/add-RSPEC-S7132 branch November 12, 2024 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomasz-kaminski-sonarsource tomasz-kaminski-sonarsource tomasz-kaminski-sonarsource approved these changes

@loic-joly-sonarsource loic-joly-sonarsource loic-joly-sonarsource left review comments

Assignees

@loic-joly-sonarsource loic-joly-sonarsource

Labels
cfamily C / C++ / Objective-C
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@loic-joly-sonarsource @tomasz-kaminski-sonarsource