Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create rule S6418 add PHP #4447

Merged
merged 5 commits into from
Oct 29, 2024
Merged

Create rule S6418 add PHP #4447

merged 5 commits into from
Oct 29, 2024

Conversation

github-actions[bot]
Copy link
Contributor

You can preview this rule here (updated a few minutes after each push).

Review

A dedicated reviewer checked the rule description successfully for:

  • logical errors and incorrect information
  • information gaps and missing content
  • text style and tone
  • PR summary and labels follow the guidelines

@github-actions github-actions bot added the iac label Oct 28, 2024
@mstachniuk mstachniuk changed the title Create rule S6418 Create rule S6418 add Ansible Oct 28, 2024
@mstachniuk mstachniuk changed the title Create rule S6418 add Ansible Create rule S6418 add PHP Oct 28, 2024
@mstachniuk mstachniuk marked this pull request as ready for review October 29, 2024 08:20
Copy link
Contributor

@loris-s-sonarsource loris-s-sonarsource left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - minor fix on the secret name, we generally use neutral names like "Example" (I can share our guidelines if needed)

rules/S6418/php/rule.adoc Outdated Show resolved Hide resolved
Co-authored-by: Loris S. <[email protected]>
Copy link

Quality Gate passed Quality Gate passed for 'rspec-tools'

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

Copy link

Quality Gate passed Quality Gate passed for 'rspec-frontend'

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

@mstachniuk mstachniuk merged commit 4b89a9d into master Oct 29, 2024
9 of 10 checks passed
@mstachniuk mstachniuk deleted the rule/S6418-add-ansible branch October 29, 2024 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants