Create rule S7129: String literal should not be assigned to mutable char pointers (CPP-5659) #4422
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
frederic-tingaud-sonarsource
changed the title
frederic-tingaud-sonarsource
requested a review
from tomasz-kaminski-sonarsource
There was a problem hiding this comment.
I do not like split on How to fix it between C and C++. The C solution are pretty valid and less impacting solution, available in C++, and I would like to just make it const.
I would personally merge the How to fix it. and have std::string_view as extra mile for C++.
Similarry, I would mention std::string and strdup as last solution, requiring memory allocation in C++/.
rules/S7129/cfamily/rule.adoc
Outdated
|
|
||
| == How to fix it | ||
|
|
||
| === {cpp} |
There was a problem hiding this comment.
I would rename the section into using `string classes in C++
rules/S7129/cfamily/rule.adoc
Outdated
| std::string s = "Hello world!"; // Compliant, mutable | ||
| ---- | ||
|
|
||
| === C |
There was a problem hiding this comment.
Rename the section:
== Keeping c-string usages (C, C++)
rules/S7129/cfamily/rule.adoc
Outdated
| mutate(s); | ||
| ---- | ||
|
|
||
| Or on the heap with `strdup`, in which case it will need to be ``free``d afterward: |
There was a problem hiding this comment.
I would have this in pitfall section about reentracy when using static.
Would also add the line after example with free, that std::strign does that automaticall.y
frederic-tingaud-sonarsource
requested a review
from tomasz-kaminski-sonarsource
tomasz-kaminski-sonarsource
changed the title
|
|
|
|
You can preview this rule here (updated a few minutes after each push).
Review
A dedicated reviewer checked the rule description successfully for: