Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SONARPY-2005: Modify rule S1721: Update rule for in (...) #4380

Merged
merged 1 commit into from
Oct 8, 2024
Merged

SONARPY-2005: Modify rule S1721: Update rule for in (...) #4380

merged 1 commit into from
Oct 8, 2024

Conversation

Seppli11
Copy link
Contributor

@Seppli11 Seppli11 commented Oct 7, 2024

Review

A dedicated reviewer checked the rule description successfully for:

  • logical errors and incorrect information
  • information gaps and missing content
  • text style and tone
  • PR summary and labels follow the guidelines

@Seppli11 Seppli11 requested a review from joke1196 October 7, 2024 15:48
@Seppli11 Seppli11 added the python label Oct 7, 2024
@Seppli11
Copy link
Contributor Author

Seppli11 commented Oct 7, 2024

I'm not sure if it would be wise to add another example for the for ... in (...) example, or maybe the description could be more clearer

@sonarqube-next SonarQube-Next
Copy link

sonarqube-next bot commented Oct 7, 2024

Quality Gate passed Quality Gate passed for 'rspec-tools'

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

@sonarqube-next SonarQube-Next
Copy link

sonarqube-next bot commented Oct 7, 2024

Quality Gate passed Quality Gate passed for 'rspec-frontend'

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

@joke1196
Copy link
Contributor

joke1196 commented Oct 8, 2024

I think it is fine like this. The change you made is clear.

@joke1196
Copy link
Contributor

joke1196 commented Oct 8, 2024

Before merging could you modify the PR name to be Modify rule S... : ... as it seems to be the standard. Thanks!

joke1196
joke1196 approved these changes Oct 8, 2024
View reviewed changes
Copy link
Contributor

@joke1196 joke1196 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for taking care of this.

@Seppli11 Seppli11 changed the title SONARPY-2005: S1721 : Update rule for in (...) SONARPY-2005: Modify rule S1721 : Update rule for in (...) Oct 8, 2024
@Seppli11 Seppli11 changed the title SONARPY-2005: Modify rule S1721 : Update rule for in (...) SONARPY-2005: Modify rule S1721: Update rule for in (...) Oct 8, 2024
@Seppli11 Seppli11 merged commit 62638f5 into master Oct 8, 2024
8 of 10 checks passed
@Seppli11 Seppli11 deleted the SONARPY-2005 branch October 8, 2024 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joke1196 joke1196 joke1196 approved these changes

Assignees
No one assigned
Labels
python
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Seppli11 @joke1196