Create rule S5849: Setting capabilities is security-sensitive #4374
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
pierre-loup-tristant-sonarsource
requested changes
Oct 8, 2024
Comment on lines
+25
to
+32
| [source,yaml] | ||
| ---- | ||
| - name: Set cap_sys_chroot+ep on /usr/bin/example | ||
| community.general.capabilities: | ||
| path: /usr/bin/example | ||
| capability: cap_sys_admin+ep # Sensitive | ||
| state: present | ||
| ---- |
There was a problem hiding this comment.
The compliant code example is missing.
There was a problem hiding this comment.
I left it away on purpose because the only compliant solution here would be not to use the module at all.
hendrik-buchwald-sonarsource
changed the title
hendrik-buchwald-sonarsource
requested a review
from pierre-loup-tristant-sonarsource
|
|
pierre-loup-tristant-sonarsource
approved these changes
Oct 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can preview this rule here (updated a few minutes after each push).
Review
A dedicated reviewer checked the rule description successfully for: