Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify S2612: add Ansible #4356

Merged
merged 4 commits into from
Oct 8, 2024

Conversation

sebastien-andrivet-sonarsource
Copy link
Contributor

Review

A dedicated reviewer checked the rule description successfully for:

  • logical errors and incorrect information
  • information gaps and missing content
  • text style and tone
  • PR summary and labels follow the guidelines

@sebastien-andrivet-sonarsource sebastien-andrivet-sonarsource changed the title Add RSPEC for S2612 Modify S2612: add Ansible Oct 1, 2024
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please have a look at the discussion in https://sonarsource.atlassian.net/browse/APPSEC-2157?focusedCommentId=670196 and, if needed, remove the code example where the mode argument is omitted.

rules/S2612/ansible/metadata.json Outdated Show resolved Hide resolved
rules/S2612/ansible/metadata.json Outdated Show resolved Hide resolved
rules/S2612/ansible/rule.adoc Outdated Show resolved Hide resolved
rules/S2612/ansible/rule.adoc Outdated Show resolved Hide resolved
Comment on lines 29 to 32
- name: Copy demo3.conf without setting permissions (default permissions)
ansible.builtin.copy:
src: /files/demo.conf
dest: /etc/demo/demo.conf

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made a comment in https://sonarsource.atlassian.net/browse/APPSEC-2157 to discuss if we should raise in the absence or the mode argument.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should not.

Copy link

sonarqube-next bot commented Oct 8, 2024

Quality Gate passed Quality Gate passed for 'rspec-tools'

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

Copy link

sonarqube-next bot commented Oct 8, 2024

Quality Gate passed Quality Gate passed for 'rspec-frontend'

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pierre-loup-tristant-sonarsource
Copy link
Contributor

Validation of links are failing but non are in the "see" section of S2612

@sebastien-andrivet-sonarsource sebastien-andrivet-sonarsource merged commit 51c5882 into master Oct 8, 2024
8 of 9 checks passed
@sebastien-andrivet-sonarsource sebastien-andrivet-sonarsource deleted the andrivet/S2612-ansible branch October 8, 2024 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants