-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Modify S2612: add Ansible #4356
Conversation
aab3d56
to
98a47ca
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please have a look at the discussion in https://sonarsource.atlassian.net/browse/APPSEC-2157?focusedCommentId=670196 and, if needed, remove the code example where the mode
argument is omitted.
rules/S2612/ansible/rule.adoc
Outdated
- name: Copy demo3.conf without setting permissions (default permissions) | ||
ansible.builtin.copy: | ||
src: /files/demo.conf | ||
dest: /etc/demo/demo.conf |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I made a comment in https://sonarsource.atlassian.net/browse/APPSEC-2157 to discuss if we should raise in the absence or the mode
argument.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should not.
Quality Gate passed for 'rspec-tools'Issues Measures |
Quality Gate passed for 'rspec-frontend'Issues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Validation of links are failing but non are in the "see" section of S2612 |
Review
A dedicated reviewer checked the rule description successfully for: