Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create rule S7053: Relative lib imports should not be used (avoid_relative_lib_imports) #4206

Merged
merged 1 commit into from
Aug 30, 2024

Conversation

github-actions[bot]
Copy link
Contributor

You can preview this rule here (updated a few minutes after each push).

Review

A dedicated reviewer checked the rule description successfully for:

  • logical errors and incorrect information
  • information gaps and missing content
  • text style and tone
  • PR summary and labels follow the guidelines

@github-actions github-actions bot added the dart label Aug 29, 2024
@antonioaversa antonioaversa changed the title Create rule S7053 Create rule S7053: Relative lib imports should not be used (avoid_relative_lib_imports) Aug 29, 2024
Copy link

Quality Gate passed Quality Gate passed for 'rspec-tools'

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

Copy link

Quality Gate passed Quality Gate passed for 'rspec-frontend'

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

@antonioaversa antonioaversa marked this pull request as ready for review August 30, 2024 15:34

== Why is this an issue?

The https://dart.dev/guides/libraries/create-packages[`lib` directory] of a Dart project is where the main code of the package is stored. Code living directly under the `lib` directory, when not explicitly declared as private with the ``++__++`` name convention, is considered the public API of the package, and can be imported via https://dart.dev/guides/packages#importing-libraries-from-packages[package imports].
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To be verified if _ is shown correctly in SQ and SC

Copy link
Contributor

@leveretka leveretka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@antonioaversa antonioaversa merged commit 2427e0e into master Aug 30, 2024
11 of 12 checks passed
@antonioaversa antonioaversa deleted the rule/add-RSPEC-S7053 branch August 30, 2024 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants