Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modify rule S6322: Migrate to LaYC format #3171

Merged
merged 3 commits into from
Sep 28, 2023
Merged

Modify rule S6322: Migrate to LaYC format #3171

merged 3 commits into from
Sep 28, 2023

Conversation

Swalkyn
Copy link
Contributor

@Swalkyn Swalkyn commented Sep 28, 2023

Review

A dedicated reviewer checked the rule description successfully for:

  • logical errors and incorrect information
  • information gaps and missing content
  • text style and tone
  • PR summary and labels follow the guidelines

@sonarqube-next
Copy link

SonarQube Quality Gate for 'rspec-tools'

Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@sonarqube-next
Copy link

SonarQube Quality Gate for 'rspec-frontend'

Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

anton-haubner-sonarsource
anton-haubner-sonarsource approved these changes Sep 28, 2023
View reviewed changes
Copy link
Contributor

@anton-haubner-sonarsource anton-haubner-sonarsource left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Swalkyn Swalkyn merged commit e2d2dd1 into master Sep 28, 2023
@Swalkyn Swalkyn deleted the sk/layc-S6322 branch September 28, 2023 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anton-haubner-sonarsource anton-haubner-sonarsource anton-haubner-sonarsource approved these changes

Assignees
No one assigned
Labels
java layc
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Swalkyn @anton-haubner-sonarsource