Modify rule S6377: Change text to education framework format (APPSEC-1110) #3164
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gaetan-ferry-sonarsource
suggested changes
Sep 29, 2023
rules/S6377/java/rule.adoc
Outdated
| == Why is this an issue? | ||
|
|
||
| include::../description.adoc[] | ||
| Before Java 17, XML Digital Signature API does not apply restrictions on XML signature validation, unless the application runs with a security manager which is rare. This can have several consequences: |
There was a problem hiding this comment.
Here the "What is the potential impact" is missing. This sentence should also be split to separate the "Why is this an issue" from the "What is the issue impact" part AKA:
- The application might improperly validate the XML signature
- The message will be trusted while actually forged by an attacker, into Auth bypass, etc.
|
SonarQube Quality Gate for 'rspec-frontend'
|
|
SonarQube Quality Gate for 'rspec-tools'
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Review
A dedicated reviewer checked the rule description successfully for: