Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modify rule S6466: Extend LaYC content #3156

Merged
merged 8 commits into from
Sep 27, 2023
Merged

Modify rule S6466: Extend LaYC content #3156

merged 8 commits into from
Sep 27, 2023

Conversation

anton-haubner-sonarsource
Copy link
Contributor

Review

A dedicated reviewer checked the rule description successfully for:

  • logical errors and incorrect information
  • information gaps and missing content
  • text style and tone
  • PR summary and labels follow the guidelines

@anton-haubner-sonarsource anton-haubner-sonarsource changed the title Modify rule S6466: Extend LaYC content for Python Modify rule S6466: Extend LaYC content Sep 26, 2023
@anton-haubner-sonarsource anton-haubner-sonarsource marked this pull request as ready for review September 27, 2023 09:24
Swalkyn
Swalkyn approved these changes Sep 27, 2023
View reviewed changes
Copy link
Contributor

@Swalkyn Swalkyn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job! The format looks good and I've left some suggestions on the content. You can decide if you want to include them or not.

rules/S6466/impact.adoc Outdated Show resolved Hide resolved
rules/S6466/java/rule.adoc Outdated Show resolved Hide resolved
rules/S6466/java/rule.adoc Outdated Show resolved Hide resolved
rules/S6466/java/rule.adoc Outdated Show resolved Hide resolved
rules/S6466/java/rule.adoc Outdated Show resolved Hide resolved
rules/S6466/python/rule.adoc Outdated Show resolved Hide resolved
rules/S6466/python/rule.adoc Show resolved Hide resolved
@sonarqube-next
Copy link

SonarQube Quality Gate for 'rspec-tools'

Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@sonarqube-next
Copy link

SonarQube Quality Gate for 'rspec-frontend'

Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@anton-haubner-sonarsource anton-haubner-sonarsource merged commit f0dc2a2 into master Sep 27, 2023
10 checks passed
@anton-haubner-sonarsource anton-haubner-sonarsource deleted the rule/modify-RSPEC-S6466 branch September 27, 2023 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Swalkyn Swalkyn Swalkyn approved these changes

Assignees
No one assigned
Labels
java layc python
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@anton-haubner-sonarsource @Swalkyn