Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify rule S6411: fix link #3033

Closed
wants to merge 1 commit into from
Closed

Conversation

marco-antognini-sonarsource
Copy link
Contributor

@marco-antognini-sonarsource marco-antognini-sonarsource commented Sep 11, 2023

Fix this issue from the CI:

Retrying 1 failed probes
https://www.kb.cert.org/vuls/id/903934 in 1 files (previously failed)
ERROR: Connection error HTTPSConnectionPool(host='www.kb.cert.org', port=443): Max retries exceeded with url: /vuls/id/903934 (Caused by SSLError(SSLCertVerificationError(1, "[SSL: CERTIFICATE_VERIFY_FAILED] certificate verify failed: Hostname mismatch, certificate is not valid for 'www.kb.cert.org'. (_ssl.c:1129)")))
There were errors
https://www.kb.cert.org/vuls/id/903934 in:
/tmp/cirrus-ci-build/rspec-tools/../out/S6411/java/rule.html
1/3037 links are dead, see above ^^ the list and the related files

Seems like the www. part of the link is not valid anymore.

Review

A dedicated reviewer checked the rule description successfully for:

  • logical errors and incorrect information
  • information gaps and missing content
  • text style and tone
  • PR summary and labels follow the guidelines

@marco-antognini-sonarsource marco-antognini-sonarsource marked this pull request as ready for review September 11, 2023 12:26
@marco-antognini-sonarsource marco-antognini-sonarsource requested a review from a team September 11, 2023 12:27
@sonarqube-next
Copy link

SonarQube Quality Gate for 'rspec-frontend'

Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@sonarqube-next
Copy link

SonarQube Quality Gate for 'rspec-tools'

Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@marco-antognini-sonarsource
Copy link
Contributor Author

@SonarSource/languages-team-jvm you can dismiss this review -- it was superseeded by #3053.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant