Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modify rule S6648: Add language AzureResourceManager (Bicep) #2277

Merged
merged 3 commits into from
Aug 2, 2023
Merged

Modify rule S6648: Add language AzureResourceManager (Bicep) #2277

merged 3 commits into from
Aug 2, 2023

Conversation

pierre-loup-tristant-sonarsource
Copy link
Contributor

@pierre-loup-tristant-sonarsource pierre-loup-tristant-sonarsource commented Jun 23, 2023 •
edited
Loading

Specification ticket
Implementation ticket

Main PR for ARM templates: #2250

Review

A dedicated reviewer checked the rule description successfully for:

  • logical errors and incorrect information
  • information gaps and missing content
  • text style and tone
  • PR summary and labels follow the guidelines

Merged
4 tasks
@pierre-loup-tristant-sonarsource pierre-loup-tristant-sonarsource force-pushed the rule/S6648-add-azureresourcemanager-bicep branch from 310ca13 to 95b85b0 Compare June 23, 2023 09:13
@sonarsource-next
Copy link

SonarQube Quality Gate for 'rspec-tools'

Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@sonarsource-next
Copy link

SonarQube Quality Gate for 'rspec-frontend'

Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

egon-okerman-sonarsource added a commit that referenced this pull request Jul 3, 2023
@github-actions @pierre-loup-tristant-sonarsource @egon-okerman-sonarsource
Create rule S6648: Secure strings and objects should not have default…
b11bd37 
… values (APPSEC-803) (#2250)

[Specification
ticket](https://sonarsource.atlassian.net/browse/APPSEC-803)
[Implementation
ticket](https://sonarsource.atlassian.net/browse/SONARIAC-896)
[RSPEC
Preview](https://sonarsource.github.io/rspec/#/rspec/S6648/azureresourcemanager)

Bicep PR: #2277

## Review

A dedicated reviewer checked the rule description successfully for:

- [x] logical errors and incorrect information
- [x] information gaps and missing content
- [x] text style and tone
- [x] PR summary and labels follow [the
guidelines](https://github.com/SonarSource/rspec/#to-modify-an-existing-rule)

---------

Co-authored-by: pierre-loup-tristant-sonarsource <[email protected]>
Co-authored-by: Pierre-Loup Tristant <[email protected]>
Co-authored-by: Egon Okerman <[email protected]>
@egon-okerman-sonarsource egon-okerman-sonarsource force-pushed the rule/S6648-add-azureresourcemanager-bicep branch 2 times, most recently from 938a24c to 34385a7 Compare July 4, 2023 07:07
egon-okerman-sonarsource
egon-okerman-sonarsource approved these changes Jul 4, 2023
View reviewed changes
Copy link
Contributor

@egon-okerman-sonarsource egon-okerman-sonarsource left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@egon-okerman-sonarsource egon-okerman-sonarsource force-pushed the rule/S6648-add-azureresourcemanager-bicep branch from 34385a7 to cf3bb89 Compare July 4, 2023 12:59
@sonarsource-next
Copy link

SonarQube Quality Gate for 'rspec-frontend'

Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@sonarsource-next
Copy link

SonarQube Quality Gate for 'rspec-tools'

Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@rudy-regazzoni-sonarsource rudy-regazzoni-sonarsource force-pushed the rule/S6648-add-azureresourcemanager-bicep branch from cf3bb89 to 2ad9e3a Compare August 2, 2023 12:45
@sonarqube-next
Copy link

sonarqube-next bot commented Aug 2, 2023

SonarQube Quality Gate for 'rspec-frontend'

Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@sonarqube-next
Copy link

sonarqube-next bot commented Aug 2, 2023

SonarQube Quality Gate for 'rspec-tools'

Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@rudy-regazzoni-sonarsource rudy-regazzoni-sonarsource merged commit 2336aba into master Aug 2, 2023
@rudy-regazzoni-sonarsource rudy-regazzoni-sonarsource deleted the rule/S6648-add-azureresourcemanager-bicep branch August 2, 2023 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@egon-okerman-sonarsource egon-okerman-sonarsource egon-okerman-sonarsource approved these changes

Assignees
No one assigned
Labels
iac
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pierre-loup-tristant-sonarsource @egon-okerman-sonarsource @rudy-regazzoni-sonarsource