Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify rule S6378: Add language AzureResourceManager (Bicep) #2255

Merged
merged 1 commit into from
Sep 13, 2023
Merged

Modify rule S6378: Add language AzureResourceManager (Bicep) #2255

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 24 additions & 0 deletions rules/S6378/azureresourcemanager/rule.adoc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,8 @@ include::../recommended.adoc[]

== Sensitive Code Example

Using ARM templates:

[source,json,diff-id=1,diff-type=noncompliant]
----
{
Expand All @@ -21,9 +23,20 @@ include::../recommended.adoc[]
}
----

Using Bicep:

[source,bicep,diff-id=2,diff-type=noncompliant]
----
resource sensitiveApiManagementService 'Microsoft.ApiManagement/service@2022-09-01-preview' = {
name: 'apiManagementService'
// Sensitive: no Managed Identity is defined
}
----

== Compliant Solution

Using ARM templates:

[source,json,diff-id=1,diff-type=compliant]
----
{
Expand All @@ -42,6 +55,17 @@ include::../recommended.adoc[]
}
----

Using Bicep:

[source,json,diff-id=2,diff-type=noncompliant]
egon-okerman-sonarsource marked this conversation as resolved.
Show resolved Hide resolved
----
resource sensitiveApiManagementService 'Microsoft.ApiManagement/service@2022-09-01-preview' = {
name: 'apiManagementService'
identity: {
type: 'SystemAssigned'
}
}
----

include::../see.adoc[]

Expand Down